Code review comment for lp:~sebastien.beau/openerp-product-attributes/openerp-product-attributes-product-dimension

Hi Sébastien,

My impression is that the dimensions should be centimeters.
At least we should have a configurable precision.

I think you can remove this TODO:

    #TODO add a function field for volume? an onchange?

If someone need a 'volume' field, he will add it, would it be an onchange or a function field, but I don't see any value for this comment.

review: Needs Information

« Back to merge proposal