Merge lp:~sebastien.beau/e-commerce-addons/e-commerce-addons-fix-picking-export into lp:~extra-addons-commiter/e-commerce-addons/oerp6.1-stable

Proposed by Sébastien BEAU - http://www.akretion.com
Status: Merged
Merged at revision: 282
Proposed branch: lp:~sebastien.beau/e-commerce-addons/e-commerce-addons-fix-picking-export
Merge into: lp:~extra-addons-commiter/e-commerce-addons/oerp6.1-stable
Diff against target: 24 lines (+5/-2)
1 file modified
base_sale_multichannels/sale.py (+5/-2)
To merge this branch: bzr merge lp:~sebastien.beau/e-commerce-addons/e-commerce-addons-fix-picking-export
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Alexandre Fayolle - camptocamp Pending
Review via email: mp+156786@code.launchpad.net

This proposal supersedes a proposal from 2013-03-19.

Description of the change

My customer just export the picking from the wizard import/export of openerp and then the picking was not exporting to magento. Indeed the SQL request was wrong, so I fix it.

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote : Posted in a previous version of this proposal

This merge is on the 7.0 branch. Can you confirm this is what you intended?

review: Needs Information
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote : Posted in a previous version of this proposal

Sébastien I definitely think that you want to merge this fix in the 6.1 branch. Can you confirm and resubmit your proposal accordingly please?

review: Needs Resubmitting
Revision history for this message
Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote :

Sorry, for the mistake, it's a fix for 6.1.

Thanks

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

LGTM

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'base_sale_multichannels/sale.py'
2--- base_sale_multichannels/sale.py 2013-01-03 10:08:13 +0000
3+++ base_sale_multichannels/sale.py 2013-04-03 09:31:21 +0000
4@@ -402,7 +402,10 @@
5 LEFT JOIN delivery_carrier
6 ON delivery_carrier.id = stock_picking.carrier_id
7 WHERE sale_order.shop_id = %(shop_id)s
8- AND ir_model_data.res_id ISNULL
9+ AND (
10+ ir_model_data.referential_id is Null
11+ OR ir_model_data.referential_id != %(referential_id)s
12+ )
13 AND stock_picking.state = 'done'
14 AND stock_picking.type = 'out'
15 AND NOT stock_picking.do_not_export
16@@ -415,7 +418,7 @@
17 stock_picking.backorder_id
18 ORDER BY sale_order.id ASC,
19 COALESCE(stock_picking.backorder_id, NULL, 0) ASC"""
20- params = {'shop_id': shop.id}
21+ params = {'shop_id': shop.id, 'referential_id': shop.referential_id.id}
22 return query, params
23
24 def export_shipping(self, cr, uid, ids, context):