Merge lp:~seb128/unity-settings-daemon/xrandr_init_order into lp:unity-settings-daemon

Proposed by Sebastien Bacher
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 4101
Merged at revision: 4104
Proposed branch: lp:~seb128/unity-settings-daemon/xrandr_init_order
Merge into: lp:unity-settings-daemon
Diff against target: 49 lines (+6/-5)
1 file modified
plugins/xrandr/gsd-xrandr-manager.c (+6/-5)
To merge this branch: bzr merge lp:~seb128/unity-settings-daemon/xrandr_init_order
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Unity Settings Daemon Development Team Pending
Review via email: mp+273728@code.launchpad.net

Commit message

[xrandr] slightly updated version of an upstream bugfix for a segfault issue

Description of the change

[xrandr] slightly updated version of an upstream bugfix for a segfault issue

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks sane to me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/xrandr/gsd-xrandr-manager.c'
--- plugins/xrandr/gsd-xrandr-manager.c 2015-08-25 08:19:38 +0000
+++ plugins/xrandr/gsd-xrandr-manager.c 2015-10-07 16:53:01 +0000
@@ -157,6 +157,7 @@
157 GsdRRRotation *out_rotations);157 GsdRRRotation *out_rotations);
158static void handle_fn_f7 (GsdXrandrManager *mgr, guint32 timestamp);158static void handle_fn_f7 (GsdXrandrManager *mgr, guint32 timestamp);
159static void handle_rotate_windows (GsdXrandrManager *mgr, GsdRRRotation rotation, guint32 timestamp);159static void handle_rotate_windows (GsdXrandrManager *mgr, GsdRRRotation rotation, guint32 timestamp);
160static void register_manager_dbus (GsdXrandrManager *manager);
160161
161G_DEFINE_TYPE (GsdXrandrManager, gsd_xrandr_manager, G_TYPE_OBJECT)162G_DEFINE_TYPE (GsdXrandrManager, gsd_xrandr_manager, G_TYPE_OBJECT)
162163
@@ -2414,6 +2415,8 @@
2414 manager->priv->running = TRUE;2415 manager->priv->running = TRUE;
2415 manager->priv->settings = g_settings_new (CONF_SCHEMA);2416 manager->priv->settings = g_settings_new (CONF_SCHEMA);
24162417
2418 register_manager_dbus (manager_object);
2419
2417 show_timestamps_dialog (manager, "Startup");2420 show_timestamps_dialog (manager, "Startup");
2418 if (!apply_stored_configuration_at_startup (manager, GDK_CURRENT_TIME)) /* we don't have a real timestamp at startup anyway */2421 if (!apply_stored_configuration_at_startup (manager, GDK_CURRENT_TIME)) /* we don't have a real timestamp at startup anyway */
2419 if (!apply_default_configuration_from_file (manager, GDK_CURRENT_TIME))2422 if (!apply_default_configuration_from_file (manager, GDK_CURRENT_TIME))
@@ -2463,6 +2466,9 @@
2463 manager->priv->upower_client = NULL;2466 manager->priv->upower_client = NULL;
2464 }2467 }
24652468
2469 if (manager->priv->name_id != 0)
2470 g_bus_unown_name (manager->priv->name_id);
2471
2466 if (manager->priv->introspection_data) {2472 if (manager->priv->introspection_data) {
2467 g_dbus_node_info_unref (manager->priv->introspection_data);2473 g_dbus_node_info_unref (manager->priv->introspection_data);
2468 manager->priv->introspection_data = NULL;2474 manager->priv->introspection_data = NULL;
@@ -2522,9 +2528,6 @@
25222528
2523 g_return_if_fail (manager->priv != NULL);2529 g_return_if_fail (manager->priv != NULL);
25242530
2525 if (manager->priv->name_id != 0)
2526 g_bus_unown_name (manager->priv->name_id);
2527
2528 G_OBJECT_CLASS (gsd_xrandr_manager_parent_class)->finalize (object);2531 G_OBJECT_CLASS (gsd_xrandr_manager_parent_class)->finalize (object);
2529}2532}
25302533
@@ -2669,8 +2672,6 @@
2669 manager_object = g_object_new (GSD_TYPE_XRANDR_MANAGER, NULL);2672 manager_object = g_object_new (GSD_TYPE_XRANDR_MANAGER, NULL);
2670 g_object_add_weak_pointer (manager_object,2673 g_object_add_weak_pointer (manager_object,
2671 (gpointer *) &manager_object);2674 (gpointer *) &manager_object);
2672
2673 register_manager_dbus (manager_object);
2674 }2675 }
26752676
2676 return GSD_XRANDR_MANAGER (manager_object);2677 return GSD_XRANDR_MANAGER (manager_object);

Subscribers

People subscribed via source and target branches