Merge lp:~seb128/ubuntuone-client-data/hook-import-error into lp:ubuntuone-client-data

[Sebastien Bacher]

Use correct apport hook syntax to avoid import error

Use correct apport hook syntax to avoid import error

current version errors out

  File "/usr/share/apport/package-hooks/source_ubuntuone-client-data.py", line 18, in <module>
    from apport.packaging import is_distro_package
ImportError: cannot import name 'is_distro_package'

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:13
http://jenkins.qa.ubuntu.com/job/ubuntuone-client-data-ci/5/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntuone-client-data-wily-amd64-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntuone-client-data-wily-armhf-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntuone-client-data-wily-i386-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntuone-client-data-ci/5/rebuild

review: Needs Fixing (continuous-integration)

[Sebastien Bacher (seb128)]

CI should be better once https://code.launchpad.net/~seb128/ubuntuone-client-data/import-pep8-valid/+merge/273408 lands

[dobey (dobey)]

Why this change?

review: Needs Information

[dobey (dobey)]

Where did is_distro_package go, rather? If it's not there, won't the hook still fail, since it's depending on that function?

[Sebastien Bacher (seb128)]

> Why this change?

Because of the error described in the "description"

> Where did is_distro_package go, rather? If it's not there, won't the hook still fail, since it's depending on that function?

I don't understand the python details enough to reply, apport.packaging.is_distro_package is an "instancemethod" and not a "function" according to type(), anyway "ubuntu-bug ubuntu-client-data" triggers currently an ImportError and works with the suggested change

[dobey (dobey)]

Seems apport broke API at some point without warning, and after looking at the apport code, it seems like this would work with new apport, but not older ones where this isn't broken.

review: Approve

[lp:~seb128/ubuntuone-client-data/hook-import-error]

13. By Sebastien Bacher on 2015-10-07

Use correct apport hook syntax to avoid import error

=== modified file 'apport/source_ubuntuone-client-data.py'
--- apport/source_ubuntuone-client-data.py	2012-09-05 21:15:26 +0000
+++ apport/source_ubuntuone-client-data.py	2015-10-07 07:18:17 +0000
@@ -15,7 +15,7 @@
 # with this program.  If not, see <http://www.gnu.org/licenses/>.
 """Stub for Apport"""
 
-from apport.packaging import is_distro_package
+import apport.packaging
 
 
 def add_info(report):