Merge lp:~seb128/ubuntuone-client-data/import-pep8-valid into lp:ubuntuone-client-data

Proposed by Sebastien Bacher
Status: Merged
Approved by: dobey
Approved revision: 13
Merged at revision: 13
Proposed branch: lp:~seb128/ubuntuone-client-data/import-pep8-valid
Merge into: lp:ubuntuone-client-data
Diff against target: 23 lines (+3/-3)
1 file modified
setup.py (+3/-3)
To merge this branch: bzr merge lp:~seb128/ubuntuone-client-data/import-pep8-valid
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
dobey (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+273408@code.launchpad.net

Commit message

list imports on top to avoid pep8 E402 errors

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Exactly this is what I did as a distro-patch for bug LP: #1503291. +1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2014-01-02 21:17:33 +0000
3+++ setup.py 2015-10-05 13:45:58 +0000
4@@ -22,6 +22,9 @@
5 import subprocess
6 import sys
7
8+from distutils.command import build
9+from distutils.spawn import find_executable
10+
11 real_setup = None
12 real_clean = None
13 if sys.platform == 'linux2':
14@@ -42,9 +45,6 @@
15 real_setup = setup
16 real_clean = clean
17
18-from distutils.command import build
19-from distutils.spawn import find_executable
20-
21 POT_FILE = 'po/ubuntuone-client-data.pot'
22
23 CLEANFILES = [POT_FILE, 'MANIFEST']

Subscribers

People subscribed via source and target branches