Merge ~seb128/ubuntu/+source/apport:ubuntu-desktop-bootstrap into ~ubuntu-core-dev/ubuntu/+source/apport:ubuntu/devel

Proposed by Sebastien Bacher
Status: Merged
Merged at revision: 50b5a4d24bb1aee18b9061a86ed3035cabb21091
Proposed branch: ~seb128/ubuntu/+source/apport:ubuntu-desktop-bootstrap
Merge into: ~ubuntu-core-dev/ubuntu/+source/apport:ubuntu/devel
Diff against target: 56 lines (+9/-9)
2 files modified
debian/package-hooks/subiquity.py (+3/-3)
debian/package-hooks/ubuntu-desktop-bootstrap.py (+6/-6)
Reviewer Review Type Date Requested Status
Benjamin Drung Approve
git-ubuntu import Pending
Review via email: mp+464195@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

The ubuntu-desktop-installer project got deprecated in favor of ubuntu-desktop-provision in noble, the new snap we use for the desktop is ubuntu-desktop-bootstrap

Revision history for this message
Benjamin Drung (bdrung) wrote :

The change looks good. Merged. It will be included in the upcoming apport release next week.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/package-hooks/subiquity.py b/debian/package-hooks/subiquity.py
index 948a8e7..0e7a406 100644
--- a/debian/package-hooks/subiquity.py
+++ b/debian/package-hooks/subiquity.py
@@ -42,10 +42,10 @@ def add_info(report, unused_ui):
42 )42 )
4343
44 # collect desktop installer details if available44 # collect desktop installer details if available
45 desktoplog = os.path.realpath("/var/log/installer/ubuntu_desktop_installer.log")45 desktoplog = os.path.realpath("/var/log/installer/ubuntu_bootstrap.log")
46 if os.path.exists(desktoplog):46 if os.path.exists(desktoplog):
47 hookutils.attach_file(report, desktoplog, "DesktopInstallerLog")47 hookutils.attach_file(report, desktoplog, "DesktopInstallerLog")
48 report.add_tags(["ubuntu-desktop-installer"])48 report.add_tags(["ubuntu-desktop-bootstrap"])
49 snapdir = os.path.realpath("/snap/ubuntu-desktop-installer/current")49 snapdir = os.path.realpath("/snap/ubuntu-desktop-bootstrap/current")
50 if os.path.exists(snapdir):50 if os.path.exists(snapdir):
51 report["DesktopInstallerRev"] = os.path.basename(snapdir)51 report["DesktopInstallerRev"] = os.path.basename(snapdir)
diff --git a/debian/package-hooks/ubuntu-desktop-installer.py b/debian/package-hooks/ubuntu-desktop-bootstrap.py
52similarity index 83%52similarity index 83%
53rename from debian/package-hooks/ubuntu-desktop-installer.py53rename from debian/package-hooks/ubuntu-desktop-installer.py
54rename to debian/package-hooks/ubuntu-desktop-bootstrap.py54rename to debian/package-hooks/ubuntu-desktop-bootstrap.py
index 6043cfe..4b39f9c 100644
--- a/debian/package-hooks/ubuntu-desktop-installer.py
+++ b/debian/package-hooks/ubuntu-desktop-bootstrap.py
@@ -1,4 +1,4 @@
1"""Send reports about ubuntu-desktop-installer to the correct Launchpad1"""Send reports about ubuntu-desktop-bootstrap to the correct Launchpad
2project."""2project."""
33
4# pylint: disable=invalid-name4# pylint: disable=invalid-name
@@ -10,19 +10,19 @@ from apport import hookutils
1010
1111
12def add_info(report, unused_ui):12def add_info(report, unused_ui):
13 """Send reports about ubuntu-desktop-installer to the correct Launchpad13 """Send reports about ubuntu-desktop-bootstrap to the correct Launchpad
14 project."""14 project."""
15 udilog = os.path.realpath("/var/log/installer/ubuntu_desktop_installer.log")15 udblog = os.path.realpath("/var/log/installer/ubuntu_bootstrap.log")
16 hookutils.attach_file_if_exists(report, udilog, "UdiLog")16 hookutils.attach_file_if_exists(report, udblog, "UdbLog")
1717
18 report["SourcePackage"] = "ubuntu-desktop-installer"18 report["SourcePackage"] = "ubuntu-desktop-bootstrap"
19 # rewrite this section so the report goes to the project in Launchpad19 # rewrite this section so the report goes to the project in Launchpad
20 report[20 report[
21 "CrashDB"21 "CrashDB"
22 ] = """\22 ] = """\
23{23{
24 "impl": "launchpad",24 "impl": "launchpad",
25 "project": "ubuntu-desktop-installer",25 "project": "ubuntu-desktop-bootstrap",
26 "bug_pattern_url": "http://people.canonical.com/"26 "bug_pattern_url": "http://people.canonical.com/"
27 "~ubuntu-archive/bugpatterns/bugpatterns.xml",27 "~ubuntu-archive/bugpatterns/bugpatterns.xml",
28}28}

Subscribers

People subscribed via source and target branches