Merge ~seb128/ubuntu/+source/apport:ubuntu-desktop-bootstrap into ~ubuntu-core-dev/ubuntu/+source/apport:ubuntu/devel

Proposed by Sebastien Bacher
Status: Merged
Merged at revision: 50b5a4d24bb1aee18b9061a86ed3035cabb21091
Proposed branch: ~seb128/ubuntu/+source/apport:ubuntu-desktop-bootstrap
Merge into: ~ubuntu-core-dev/ubuntu/+source/apport:ubuntu/devel
Diff against target: 56 lines (+9/-9)
2 files modified
debian/package-hooks/subiquity.py (+3/-3)
debian/package-hooks/ubuntu-desktop-bootstrap.py (+6/-6)
Reviewer Review Type Date Requested Status
Benjamin Drung Approve
git-ubuntu import Pending
Review via email: mp+464195@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

The ubuntu-desktop-installer project got deprecated in favor of ubuntu-desktop-provision in noble, the new snap we use for the desktop is ubuntu-desktop-bootstrap

Revision history for this message
Benjamin Drung (bdrung) wrote :

The change looks good. Merged. It will be included in the upcoming apport release next week.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/package-hooks/subiquity.py b/debian/package-hooks/subiquity.py
2index 948a8e7..0e7a406 100644
3--- a/debian/package-hooks/subiquity.py
4+++ b/debian/package-hooks/subiquity.py
5@@ -42,10 +42,10 @@ def add_info(report, unused_ui):
6 )
7
8 # collect desktop installer details if available
9- desktoplog = os.path.realpath("/var/log/installer/ubuntu_desktop_installer.log")
10+ desktoplog = os.path.realpath("/var/log/installer/ubuntu_bootstrap.log")
11 if os.path.exists(desktoplog):
12 hookutils.attach_file(report, desktoplog, "DesktopInstallerLog")
13- report.add_tags(["ubuntu-desktop-installer"])
14- snapdir = os.path.realpath("/snap/ubuntu-desktop-installer/current")
15+ report.add_tags(["ubuntu-desktop-bootstrap"])
16+ snapdir = os.path.realpath("/snap/ubuntu-desktop-bootstrap/current")
17 if os.path.exists(snapdir):
18 report["DesktopInstallerRev"] = os.path.basename(snapdir)
19diff --git a/debian/package-hooks/ubuntu-desktop-installer.py b/debian/package-hooks/ubuntu-desktop-bootstrap.py
20similarity index 83%
21rename from debian/package-hooks/ubuntu-desktop-installer.py
22rename to debian/package-hooks/ubuntu-desktop-bootstrap.py
23index 6043cfe..4b39f9c 100644
24--- a/debian/package-hooks/ubuntu-desktop-installer.py
25+++ b/debian/package-hooks/ubuntu-desktop-bootstrap.py
26@@ -1,4 +1,4 @@
27-"""Send reports about ubuntu-desktop-installer to the correct Launchpad
28+"""Send reports about ubuntu-desktop-bootstrap to the correct Launchpad
29 project."""
30
31 # pylint: disable=invalid-name
32@@ -10,19 +10,19 @@ from apport import hookutils
33
34
35 def add_info(report, unused_ui):
36- """Send reports about ubuntu-desktop-installer to the correct Launchpad
37+ """Send reports about ubuntu-desktop-bootstrap to the correct Launchpad
38 project."""
39- udilog = os.path.realpath("/var/log/installer/ubuntu_desktop_installer.log")
40- hookutils.attach_file_if_exists(report, udilog, "UdiLog")
41+ udblog = os.path.realpath("/var/log/installer/ubuntu_bootstrap.log")
42+ hookutils.attach_file_if_exists(report, udblog, "UdbLog")
43
44- report["SourcePackage"] = "ubuntu-desktop-installer"
45+ report["SourcePackage"] = "ubuntu-desktop-bootstrap"
46 # rewrite this section so the report goes to the project in Launchpad
47 report[
48 "CrashDB"
49 ] = """\
50 {
51 "impl": "launchpad",
52- "project": "ubuntu-desktop-installer",
53+ "project": "ubuntu-desktop-bootstrap",
54 "bug_pattern_url": "http://people.canonical.com/"
55 "~ubuntu-archive/bugpatterns/bugpatterns.xml",
56 }

Subscribers

People subscribed via source and target branches