Merge lp:~seb128/ubuntu-system-settings/system-update-logo into lp:ubuntu-system-settings

Proposed by Sebastien Bacher
Status: Merged
Approved by: Ken VanDine
Approved revision: 1507
Merged at revision: 1522
Proposed branch: lp:~seb128/ubuntu-system-settings/system-update-logo
Merge into: lp:ubuntu-system-settings
Diff against target: 43 lines (+5/-3)
3 files modified
plugins/system-update/CMakeLists.txt (+1/-1)
plugins/system-update/PageComponent.qml (+3/-1)
plugins/system-update/system_update.cpp (+1/-1)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/system-update-logo
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+269243@code.launchpad.net

Commit message

[system-update] use scalable distributor-logo icon from the theme

Description of the change

[system-update] use scalable distributor-logo icon from the theme

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks great, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/system-update/CMakeLists.txt'
--- plugins/system-update/CMakeLists.txt 2014-10-22 19:37:42 +0000
+++ plugins/system-update/CMakeLists.txt 2015-08-26 16:46:02 +0000
@@ -25,7 +25,7 @@
25install(FILES ${QML_SOURCES} DESTINATION ${PLUGIN_QML_DIR}/system-update)25install(FILES ${QML_SOURCES} DESTINATION ${PLUGIN_QML_DIR}/system-update)
2626
27install(FILES system-update.settings DESTINATION ${PLUGIN_MANIFEST_DIR})27install(FILES system-update.settings DESTINATION ${PLUGIN_MANIFEST_DIR})
28install(FILES images/settings-system-update.svg images/distributor-logo.png DESTINATION ${PLUGIN_MANIFEST_DIR}/icons)28install(FILES images/settings-system-update.svg DESTINATION ${PLUGIN_MANIFEST_DIR}/icons)
2929
3030
31set(QML_SOURCES_NOTIFICATION EntryComponent.qml)31set(QML_SOURCES_NOTIFICATION EntryComponent.qml)
3232
=== modified file 'plugins/system-update/PageComponent.qml'
--- plugins/system-update/PageComponent.qml 2015-06-29 13:06:41 +0000
+++ plugins/system-update/PageComponent.qml 2015-08-26 16:46:02 +0000
@@ -714,8 +714,10 @@
714 spacing: units.gu(2)714 spacing: units.gu(2)
715715
716 Image {716 Image {
717 source: Qt.resolvedUrl("file:///usr/share/ubuntu/settings/system/icons/distributor-logo.png")717 source: Qt.resolvedUrl("file:///usr/share/icons/suru/places/scalable/distributor-logo.svg")
718 anchors.horizontalCenter: parent.horizontalCenter718 anchors.horizontalCenter: parent.horizontalCenter
719 height: width
720 width: 96
719 NumberAnimation on rotation {721 NumberAnimation on rotation {
720 from: 0722 from: 0
721 to: 360723 to: 360
722724
=== removed file 'plugins/system-update/images/distributor-logo.png'
723Binary files plugins/system-update/images/distributor-logo.png 2014-01-23 19:29:34 +0000 and plugins/system-update/images/distributor-logo.png 1970-01-01 00:00:00 +0000 differ725Binary files plugins/system-update/images/distributor-logo.png 2014-01-23 19:29:34 +0000 and plugins/system-update/images/distributor-logo.png 1970-01-01 00:00:00 +0000 differ
=== modified file 'plugins/system-update/system_update.cpp'
--- plugins/system-update/system_update.cpp 2015-07-13 18:26:10 +0000
+++ plugins/system-update/system_update.cpp 2015-08-26 16:46:02 +0000
@@ -232,7 +232,7 @@
232 update->setSelected(downloading);232 update->setSelected(downloading);
233 update->setUpdateAvailable(isAvailable);233 update->setUpdateAvailable(isAvailable);
234 update->setLastUpdateDate(lastUpdateDate);234 update->setLastUpdateDate(lastUpdateDate);
235 update->setIconUrl(QString("file:///usr/share/ubuntu/settings/system/icons/distributor-logo.png"));235 update->setIconUrl(QString("file:///usr/share/icons/suru/places/scalable/distributor-logo.svg"));
236236
237 if (update->updateRequired()) {237 if (update->updateRequired()) {
238 Q_EMIT updateAvailable(packageName, update);238 Q_EMIT updateAvailable(packageName, update);

Subscribers

People subscribed via source and target branches