Code review comment for lp:~seb128/ubuntu-system-settings/storage-bar-border

Revision history for this message
Alberto Mardegan (mardy) wrote :

I'd prefer to use the anchors properties instead of assigning the width, that is instead of having:

 anchors.horizontalCenter: parent.horizontalCenter
 width: parent.width - units.gu(4)

have

 anchors.left: parent.left
 anchors.right: parent.right
 anchors.leftMargin: units.gu(2)
 anchors.rightMargin: anchors.leftMargin

which makes it more declarative, but it's just my preference.

review: Approve

« Back to merge proposal