Merge lp:~seb128/ubuntu-system-settings/security-ui-tweaks into lp:ubuntu-system-settings

Proposed by Sebastien Bacher
Status: Merged
Approved by: Ken VanDine
Approved revision: 1512
Merged at revision: 1520
Proposed branch: lp:~seb128/ubuntu-system-settings/security-ui-tweaks
Merge into: lp:ubuntu-system-settings
Diff against target: 104 lines (+38/-8)
2 files modified
plugins/security-privacy/AppAccess.qml (+35/-5)
plugins/security-privacy/PageComponent.qml (+3/-3)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/security-ui-tweaks
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ken VanDine Approve
Review via email: mp+268625@code.launchpad.net

Commit message

[security-privacy] small bugfixes and ui tweaks
- update some strings to match the design
- translate the list items names
- include online accounts button

Description of the change

[security-privacy] small bugfixes and ui tweaks
- update some strings to match the design
- translate the list items names
- include online accounts button

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1508. By Sebastien Bacher

rename "mic" to "microphone"

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

This looks great, but while your changing these strings please also change "Other app access" to "App permissions" per the spec.

review: Needs Fixing
1509. By Sebastien Bacher

rename page 'app permissions' to match the spec

1510. By Sebastien Bacher

include location permissions in the list

1511. By Sebastien Bacher

show chevrons on items with are enabled

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1512. By Sebastien Bacher

some extra tweaks

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good and works great

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/security-privacy/AppAccess.qml'
--- plugins/security-privacy/AppAccess.qml 2015-07-13 12:09:52 +0000
+++ plugins/security-privacy/AppAccess.qml 2015-08-24 15:29:59 +0000
@@ -25,7 +25,7 @@
2525
26ItemPage {26ItemPage {
27 id: root27 id: root
28 title: i18n.tr("Other app access")28 title: i18n.tr("App permissions")
2929
30 Flickable {30 Flickable {
31 anchors.fill: parent31 anchors.fill: parent
@@ -43,7 +43,7 @@
43 anchors.right: parent.right43 anchors.right: parent.right
4444
45 ListItem.Caption {45 ListItem.Caption {
46 text: i18n.tr("Apps that you have granted and have requested access to:")46 text: i18n.tr("Apps that you have granted access to:")
47 }47 }
4848
49 ListModel {49 ListModel {
@@ -54,8 +54,13 @@
54 trustStoreService: "CameraService"54 trustStoreService: "CameraService"
55 }55 }
56 ListElement {56 ListElement {
57 name: QT_TR_NOOP("Mic")57 name: QT_TR_NOOP("Location")
58 caption: QT_TR_NOOP("Apps that have requested access to your mic")58 caption: QT_TR_NOOP("Apps that have requested access to your location")
59 trustStoreService: "UbuntuLocationService"
60 }
61 ListElement {
62 name: QT_TR_NOOP("Microphone")
63 caption: QT_TR_NOOP("Apps that have requested access to your microphone")
59 trustStoreService: "PulseAudio"64 trustStoreService: "PulseAudio"
60 }65 }
61 }66 }
@@ -64,8 +69,9 @@
64 model: appsModel69 model: appsModel
6570
66 ListItem.SingleValue {71 ListItem.SingleValue {
67 text: model.name72 text: i18n.tr(model.name)
68 enabled: trustStoreModel.count > 073 enabled: trustStoreModel.count > 0
74 progression: enabled ? true : false
69 value: trustStoreModel.count > 0 ?75 value: trustStoreModel.count > 0 ?
70 i18n.tr("%1/%2").arg(trustStoreModel.grantedCount).arg(trustStoreModel.count) :76 i18n.tr("%1/%2").arg(trustStoreModel.grantedCount).arg(trustStoreModel.count) :
71 i18n.tr("0")77 i18n.tr("0")
@@ -81,6 +87,30 @@
81 }87 }
82 }88 }
83 }89 }
90
91 ListItem.Caption {
92 text: i18n.tr("Apps may also request access to online accounts.")
93 }
94
95 ListItem.SingleControl {
96 control: Button {
97 text: i18n.tr("Online Accounts…")
98 width: parent.width - units.gu(4)
99 onClicked: {
100 var upPlugin = pluginManager.getByName("online-accounts")
101 if (upPlugin) {
102 var updatePage = upPlugin.pageComponent
103 if (updatePage)
104 pageStack.push(updatePage)
105 else
106 console.warn("online-accounts")
107 } else {
108 console.warn("online-accounts")
109 }
110 }
111 }
112 showDivider: false
113 }
84 }114 }
85 }115 }
86}116}
87117
=== modified file 'plugins/security-privacy/PageComponent.qml'
--- plugins/security-privacy/PageComponent.qml 2015-05-21 13:32:41 +0000
+++ plugins/security-privacy/PageComponent.qml 2015-08-24 15:29:59 +0000
@@ -207,7 +207,7 @@
207 ListItem.SingleValue {207 ListItem.SingleValue {
208 id: locationItem208 id: locationItem
209 objectName: "locationItem"209 objectName: "locationItem"
210 text: i18n.tr("Location access")210 text: i18n.tr("Location")
211 value: ""211 value: ""
212 progression: true212 progression: true
213 onClicked: pageStack.push(Qt.resolvedUrl("Location.qml"))213 onClicked: pageStack.push(Qt.resolvedUrl("Location.qml"))
@@ -225,9 +225,9 @@
225 value: locationActionGroup.enabled.state225 value: locationActionGroup.enabled.state
226 }226 }
227 ListItem.SingleValue {227 ListItem.SingleValue {
228 text: i18n.tr("Other app access")228 text: i18n.tr("App permissions")
229 progression: true229 progression: true
230 onClicked: pageStack.push(Qt.resolvedUrl("AppAccess.qml"))230 onClicked: pageStack.push(Qt.resolvedUrl("AppAccess.qml"), {pluginManager: pluginManager})
231 }231 }
232 ListItem.SingleValue {232 ListItem.SingleValue {
233 text: i18n.tr("Diagnostics")233 text: i18n.tr("Diagnostics")

Subscribers

People subscribed via source and target branches