Merge lp:~seb128/ubuntu-system-settings/disable-osk-predictive-text into lp:ubuntu-system-settings

Proposed by Sebastien Bacher
Status: Merged
Approved by: Iain Lane
Approved revision: 580
Merged at revision: 585
Proposed branch: lp:~seb128/ubuntu-system-settings/disable-osk-predictive-text
Merge into: lp:ubuntu-system-settings
Diff against target: 48 lines (+4/-1)
4 files modified
plugins/bluetooth/ProvidePasskeyDialog.qml (+1/-1)
plugins/bluetooth/ProvidePinCodeDialog.qml (+1/-0)
plugins/time-date/ChooseTimeZone.qml (+1/-0)
src/qml/MainWindow.qml (+1/-0)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/disable-osk-predictive-text
Reviewer Review Type Date Requested Status
Iain Lane Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+203376@code.launchpad.net

Commit message

disable the osk predictive text, so results are shown while typing

Description of the change

disable the osk predictive text, so results are shown while typing

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Iain Lane (laney) wrote :

Interesting, is this why we got that bug the other day? Like - the keyboard doesn't send results to the application in this case?

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

> Interesting, is this why we got that bug the other day? Like - the keyboard doesn't send results to the application in this case?

yes, if you enable those osk options, while the word is displayed in blue (listing different suggestions) the input is not making it to the widget, you need to "valide" a word to have it entered...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/bluetooth/ProvidePasskeyDialog.qml'
--- plugins/bluetooth/ProvidePasskeyDialog.qml 2013-09-23 02:50:33 +0000
+++ plugins/bluetooth/ProvidePasskeyDialog.qml 2014-01-27 17:10:14 +0000
@@ -45,7 +45,7 @@
45 text: "000000"45 text: "000000"
46 focus: true46 focus: true
47 Component.onCompleted: selectAll()47 Component.onCompleted: selectAll()
48 inputMethodHints: Qt.ImhDigitsOnly48 inputMethodHints: Qt.ImhDigitsOnly | Qt.ImhNoPredictiveText
49 }49 }
5050
51 Row {51 Row {
5252
=== modified file 'plugins/bluetooth/ProvidePinCodeDialog.qml'
--- plugins/bluetooth/ProvidePinCodeDialog.qml 2013-09-27 14:55:26 +0000
+++ plugins/bluetooth/ProvidePinCodeDialog.qml 2014-01-27 17:10:14 +0000
@@ -46,6 +46,7 @@
46 focus: true46 focus: true
47 Component.onCompleted: selectAll()47 Component.onCompleted: selectAll()
48 maximumLength: 1648 maximumLength: 16
49 inputMethodHints: Qt.ImhNoPredictiveText
49 }50 }
5051
51 Row {52 Row {
5253
=== modified file 'plugins/time-date/ChooseTimeZone.qml'
--- plugins/time-date/ChooseTimeZone.qml 2013-10-02 11:42:06 +0000
+++ plugins/time-date/ChooseTimeZone.qml 2014-01-27 17:10:14 +0000
@@ -68,6 +68,7 @@
68 onTextChanged: timeDatePanel.filter = text68 onTextChanged: timeDatePanel.filter = text
69 visible: setTimeZoneSelector.selectedIndex == 1 // Manually69 visible: setTimeZoneSelector.selectedIndex == 1 // Manually
70 Component.onCompleted: forceActiveFocus()70 Component.onCompleted: forceActiveFocus()
71 inputMethodHints: Qt.ImhNoPredictiveText
71 Connections {72 Connections {
72 target: setTimeZoneSelector73 target: setTimeZoneSelector
73 onSelectedIndexChanged: {74 onSelectedIndexChanged: {
7475
=== modified file 'src/qml/MainWindow.qml'
--- src/qml/MainWindow.qml 2013-12-20 15:58:05 +0000
+++ src/qml/MainWindow.qml 2014-01-27 17:10:14 +0000
@@ -124,6 +124,7 @@
124 width: parent.width - units.gu(4)124 width: parent.width - units.gu(4)
125 placeholderText: i18n.tr("Search")125 placeholderText: i18n.tr("Search")
126 objectName: "searchTextField"126 objectName: "searchTextField"
127 inputMethodHints: Qt.ImhNoPredictiveText
127 onDisplayTextChanged:128 onDisplayTextChanged:
128 pluginManager.filter = displayText129 pluginManager.filter = displayText
129 }130 }

Subscribers

People subscribed via source and target branches