Merge lp:~seb128/ubuntu-system-settings/bluetooth-null-device into lp:ubuntu-system-settings
Proposed by
Sebastien Bacher
Status: | Merged |
---|---|
Approved by: | Ken VanDine |
Approved revision: | 1337 |
Merged at revision: | 1384 |
Proposed branch: | lp:~seb128/ubuntu-system-settings/bluetooth-null-device |
Merge into: | lp:ubuntu-system-settings |
Diff against target: |
18 lines (+5/-3) 1 file modified
plugins/bluetooth/devicemodel.cpp (+5/-3) |
To merge this branch: | bzr merge lp:~seb128/ubuntu-system-settings/bluetooth-null-device |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ken VanDine | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+250895@code.launchpad.net |
Commit message
bluetooth: check if the device is valid before getting details
Description of the change
bluetooth: check if the device is valid before getting details
Not sure what are the exact steps to get into that case but DeviceModel:
" auto device = getDeviceFromPa
const int row = findRowFromAddr
or getDeviceFromPath() can return a null value, which leads to a segfault (saw that on a krillin device a few time while trying to pair the phone with a car (which was not working, but that's another issue)
To post a comment you must log in.
FAILED: Continuous integration, rev:1336 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- ci/2003/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 1519 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- vivid-i386- ci/273 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 1350 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1517 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1517/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 18330
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- system- settings- ci/2003/ rebuild
http://