Merge lp:~seb128/ubuntu-system-settings/background-revert-new-content-hub into lp:ubuntu-system-settings

Proposed by Sebastien Bacher
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 391
Merged at revision: 391
Proposed branch: lp:~seb128/ubuntu-system-settings/background-revert-new-content-hub
Merge into: lp:ubuntu-system-settings
Diff against target: 46 lines (+6/-23)
1 file modified
plugins/background/MainPage.qml (+6/-23)
To merge this branch: bzr merge lp:~seb128/ubuntu-system-settings/background-revert-new-content-hub
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Łukasz Zemczak Approve
Review via email: mp+187807@code.launchpad.net

Commit message

background: revert use of the new content-hub, it's buggy (see bug #1231368)

Description of the change

background: revert use of the new content-hub, it's buggy

To post a comment you must log in.
391. By Sebastien Bacher

background: revert use of the new content-hub, it's buggy (see bug #1231368)

Revision history for this message
Sebastien Bacher (seb128) wrote :

that's reverting r372

Revision history for this message
Łukasz Zemczak (sil2100) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/background/MainPage.qml'
--- plugins/background/MainPage.qml 2013-09-23 19:45:35 +0000
+++ plugins/background/MainPage.qml 2013-09-26 14:53:02 +0000
@@ -77,18 +77,9 @@
77 }77 }
7878
79 onClicked: {79 onClicked: {
80 var transfer = ContentHub.importContent(ContentType.Pictures,80 activeTransfer = ContentHub.importContent(ContentType.Pictures,
81 ContentHub.defaultSourceForType(ContentType.Pictures));81 ContentHub.defaultSourceForType(ContentType.Pictures));
82 if (transfer != null)82 activeTransfer.start();
83 {
84 transfer.selectionType = ContentTransfer.Single;
85 var store = ContentHub.defaultStoreForType(ContentType.Pictures);
86 console.log("Store is: " + store.uri);
87 transfer.setStore(store);
88 activeTransfer = transfer;
89 activeTransfer.start();
90 }
91
92 }83 }
9384
94 Component.onCompleted: updateImage(testWelcomeImage,85 Component.onCompleted: updateImage(testWelcomeImage,
@@ -112,17 +103,9 @@
112 homeImage)103 homeImage)
113104
114 onClicked: {105 onClicked: {
115 var transfer = ContentHub.importContent(ContentType.Pictures,106 activeTransfer = ContentHub.importContent(ContentType.Pictures,
116 ContentHub.defaultSourceForType(ContentType.Pictures));107 ContentHub.defaultSourceForType(ContentType.Pictures));
117 if (transfer != null)108 activeTransfer.start();
118 {
119 transfer.selectionType = ContentTransfer.Single;
120 var store = ContentHub.defaultStoreForType(ContentType.Pictures);
121 console.log("Store is: " + store.uri);
122 transfer.setStore(store);
123 activeTransfer = transfer;
124 activeTransfer.start();
125 }
126 }109 }
127110
128 OverlayImage {111 OverlayImage {

Subscribers

People subscribed via source and target branches