ubiquity

Merge ~seb128/ubiquity:question-label-width into ubiquity:master

  1. Git
  2. lp:~seb128/ubiquity
  3. question-label-width
  4. Merge into master
Proposed by Sebastien Bacher
Status: Merged
Merged at revision: 4d46311f1db6026a5140a2ffe453d608cea37236
Proposed branch: ~seb128/ubiquity:question-label-width
Merge into: ubiquity:master
Diff against target: 12 lines (+1/-0)
1 file modified
gui/gtk/ubiquity.ui (+1/-0)
Reviewer Review Type Date Requested Status
Jean-Baptiste Lallement Approve
Review via email: mp+382861@code.launchpad.net

Commit message

ubiquity.ui: set max-width-chars on the question label

Description of the change

Screenshot showing the issue (starting ubiquity on an installed system triggers the dialog)

Before
https://people.canonical.com/~seb128/ubiquity/before.png

Now with the code change
https://people.canonical.com/~seb128/ubiquity/now.png

To post a comment you must log in.
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

LGTM, Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/gui/gtk/ubiquity.ui b/gui/gtk/ubiquity.ui
2index 601b724..ec35580 100644
3--- a/gui/gtk/ubiquity.ui
4+++ b/gui/gtk/ubiquity.ui
5@@ -1112,6 +1112,7 @@
6 <property name="can_focus">False</property>
7 <property name="label" translatable="yes">label</property>
8 <property name="wrap">True</property>
9+ <property name="max-width-chars">90</property>
10 </object>
11 <packing>
12 <property name="expand">False</property>

Subscribers

People subscribed via source and target branches