telephony-service

Merge lp:~seb128/telephony-service/dont-unref-gvariant into lp:telephony-service/rtm-15.04

  1. dont-unref-gvariant
  2. Merge into rtm-15.04
Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 1040
Merged at revision: 1099
Proposed branch: lp:~seb128/telephony-service/dont-unref-gvariant
Merge into: lp:telephony-service/rtm-15.04
Diff against target: 11 lines (+0/-1)
1 file modified
indicator/messagingmenu.cpp (+0/-1)
To merge this branch: bzr merge lp:~seb128/telephony-service/dont-unref-gvariant
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann Pending
PS Jenkins bot continuous-integration Pending
Review via email: mp+263928@code.launchpad.net

This proposal supersedes a proposal from 2015-03-10.

Commit message

don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue

Description of the change

don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:1040
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/375/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/43
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/43
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/43/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/43

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/375/rebuild

review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote : Posted in a previous version of this proposal

Looks good. Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'indicator/messagingmenu.cpp'
2--- indicator/messagingmenu.cpp 2015-06-11 16:38:02 +0000
3+++ indicator/messagingmenu.cpp 2015-07-06 16:11:14 +0000
4@@ -251,7 +251,6 @@
5 messaging_menu_app_append_message(mCallsApp, message, SOURCE_ID, true);
6 mCalls.append(call);
7
8- g_variant_unref(messages);
9 g_object_unref(file);
10 g_object_unref(icon);
11 g_object_unref(message);

Subscribers

People subscribed via source and target branches