Merge lp:~seb128/telephony-service/dont-unref-gvariant into lp:telephony-service

[Sebastien Bacher]

don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue

don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue

[lp:~seb128/telephony-service/dont-unref-gvariant]

1040. By Sebastien Bacher on 2015-03-10

don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1040
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/375/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/43
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/43
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/43/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/43

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/375/rebuild

review: Approve (continuous-integration)

[Tiago Salem Herrmann (tiagosh)]

Looks good. Thanks.

review: Approve

Unmerged revisions

=== modified file 'indicator/messagingmenu.cpp'
--- indicator/messagingmenu.cpp	2015-02-04 20:42:14 +0000
+++ indicator/messagingmenu.cpp	2015-03-10 11:10:33 +0000
@@ -236,7 +236,6 @@
     messaging_menu_app_append_message(mCallsApp, message, SOURCE_ID, true);
     mCalls.append(call);
 
-    g_variant_unref(messages);
     g_object_unref(file);
     g_object_unref(icon);
     g_object_unref(message);