telephony-service

Merge lp:~seb128/telephony-service/dont-unref-gvariant into lp:telephony-service

  1. dont-unref-gvariant
  2. Merge into trunk
Proposed by Sebastien Bacher on 2015-03-10
Status: Superseded
Proposed branch: lp:~seb128/telephony-service/dont-unref-gvariant
Merge into: lp:telephony-service
Diff against target: 11 lines (+0/-1)
1 file modified
indicator/messagingmenu.cpp (+0/-1)
To merge this branch: bzr merge lp:~seb128/telephony-service/dont-unref-gvariant
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) 2015-03-10 Approve on 2015-03-30
PS Jenkins bot continuous-integration Approve on 2015-03-10
Review via email: mp+252415@code.launchpad.net

This proposal has been superseded by a proposal from 2015-07-06.

Commit Message

don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue

Description of the Change

don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue

To post a comment you must log in.
lp:~seb128/telephony-service/dont-unref-gvariant updated on 2015-03-10
1040. By Sebastien Bacher on 2015-03-10

don't unref a non owned variant, g_variant_new_strv() returns a floating
reference which is consumed by calling messaging_menu_message_add_action()
thanks Lars Uebernickel for pointing the issue

PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Tiago Salem Herrmann (tiagosh) wrote :

Looks good. Thanks.

review: Approve

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'indicator/messagingmenu.cpp'
2--- indicator/messagingmenu.cpp 2015-02-04 20:42:14 +0000
3+++ indicator/messagingmenu.cpp 2015-03-10 11:10:33 +0000
4@@ -236,7 +236,6 @@
5 messaging_menu_app_append_message(mCallsApp, message, SOURCE_ID, true);
6 mCalls.append(call);
7
8- g_variant_unref(messages);
9 g_object_unref(file);
10 g_object_unref(icon);
11 g_object_unref(message);

Subscribers

People subscribed via source and target branches