Code review comment for lp:~seb128/software-properties/dont-use-deprecated-reboot-commands

Revision history for this message
Michael Vogt (mvo) wrote :

On Thu, Oct 17, 2013 at 09:13:32PM -0000, Sebastien Bacher wrote:
> Sebastien Bacher has proposed merging lp:~seb128/software-properties/dont-use-deprecated-reboot-commands into lp:software-properties.
>
> Commit message:
> Don't use a deprecated binary to reboot
>
> Requested reviews:
> Ubuntu Core Development Team (ubuntu-core-dev)
> Related bugs:
> Bug #1241210 in software-properties (Ubuntu): "shouldn't use deprecated gtk-logout-helper"
> https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/1241210
>
> For more details, see:
> https://code.launchpad.net/~seb128/software-properties/dont-use-deprecated-reboot-commands/+merge/191720
>
> Don't use a deprecated binary to reboot

Looks good, +1

Cheers,
 Michael

« Back to merge proposal