Code review comment for lp:~seb128/phone-app/ringtone-in-gsettings

Revision history for this message
Lars Karlitski (larsu) wrote :

> I've no strong opinion, I went with the current approch since it allows to set
> a file anywhere on disk (e.g a music from your xdg music dir), I'm not sure if
> you can do that with the theme spec.
>
> I think the spec makes sense for system effects for example, maybe not in that
> "custom sound" case

Okay, that makes sense.

Thanks for the quick fixes. Looks good to me now.

review: Approve

« Back to merge proposal