Code review comment for lp:~seb128/phone-app/ringtone-in-gsettings

Revision history for this message
Lars Karlitski (larsu) wrote :

> +find_library(QGSETTINGS_LIB gsettings-qt)

The cmake-foo is not strong with me, but I think you should use something like find_package here to pick up the pkg-config file.

> +#include <QGSettings/QGSettings>

This should only be "#include <QGSettings>". The pkgconfig file already points to the QGSettings directory, so that should work as soon as you pull in its cflags.

schemas/com.ubuntu.touch.phone-app.gschema.xml.in:
  * the summary and description for incoming-call-sound and incoming-message-sound are the same
  * the absolute paths are a bit weird - don't we have sound themes based on xdg dirs like we do for icons?

review: Needs Fixing

« Back to merge proposal