Code review comment for lp:~sdague/do-plugins/sean

Alex Launi wrote:
>> The nomachine NX packages for debian/ubuntu put it in that location, and
>> do not add it to the path. You have to manually launch it from that
>> path, or use the desktop launching files in the menu.
>
> hardcoding is just bad all around, you should file a bug with that package because that's not where it's supposed to go. The plugin should look on $PATH, if a user has a nonstandard path (either because they did it themself, or weird packages), then they can add that path to $PATH.

It's a commercial (free beer) package (http://www.nomachine.com/), not
something that is changable in the distro. While it is probably bad, it
is consistant, and has been in the same path location for the last 2
years that I've been using it.

The question is basically whether the plugin works out of the box or
requires the user to change his/her PATH to include the nx location
prior to it working.

 -Sean

--
__________________________________________________________________

Sean Dague Mid-Hudson Valley
sean at dague dot net Linux Users Group
http://dague.net http://mhvlug.org

There is no silver bullet. Plus, werewolves make better neighbors
than zombies, and they tend to keep the vampire population down.
__________________________________________________________________