Stellarium

Merge lp:~scrupeus/stellarium/fix-edit-datetime into lp:stellarium

  1. fix-edit-datetime
  2. Merge into trunk
Proposed by Peter Mousley
Status: Merged
Merged at revision: 4722
Proposed branch: lp:~scrupeus/stellarium/fix-edit-datetime
Merge into: lp:stellarium
Diff against target: 0 lines
To merge this branch: bzr merge lp:~scrupeus/stellarium/fix-edit-datetime
Reviewer Review Type Date Requested Status
Fabien Chéreau Approve
Review via email: mp+30483@code.launchpad.net

Description of the change

Fix to allow easy editing of date/time seconds.
Also applied to minutes setting but it seems unnecessary for hours/date.

To post a comment you must log in.
Revision history for this message
Fabien Chéreau (xalioth) wrote :

It's OK for me. It seems that I still have problem editing the day field though.

review: Approve
Revision history for this message
Peter Mousley (scrupeus) wrote :

On 22/07/2010 3:11, Fabien Chéreau wrote:
> It seems that I still have problem editing the day field though.
>

Can you elaborate?

Revision history for this message
Fabien Chéreau (xalioth) wrote :

If you try to edit the month or day with the keyboard you can only enter values which are valid after each key press, even for transient values. For example it's not possible to delete the month field and retype another number.

But this is a bug disconnected with your patch, so could be reported somewhere else.
Fabien

Revision history for this message
Peter Mousley (scrupeus) wrote :

On 28/07/2010 1:03, Fabien Chéreau wrote:
> If you try to edit the month or day with the keyboard you can only enter values which are valid after each key press, even for transient values. For example it's not possible to delete the month field and retype another number.
>
> But this is a bug disconnected with your patch, so could be reported somewhere else.
> Fabien
>

I'm making a few changes related to setting date-time, which should fix
that. New commit coming soon...

Preview Diff

Empty