Code review comment for lp:~scigghia/account-invoicing/adding_account_invoice_shipping_address_7

Revision history for this message
Leonardo Pistone (lepistone) wrote :

Andrea,
I would fix refactor a bit to make flake8 pass. I think everything except the first two lines in __init__.py can be fixed (those two are actually correct).

Thanks!

Here is the output:

./__init__.py:23:1: F401 'invoice' imported but unused
./__init__.py:24:1: F401 'sale' imported but unused
./__openerp__.py:30:80: E501 line too long (102 > 79 characters)
./invoice.py:23:1: F401 'osv' imported but unused
./invoice.py:23:23: E231 missing whitespace after ','
./invoice.py:24:1: F401 '_' imported but unused
./invoice.py:26:1: E302 expected 2 blank lines, found 1
./invoice.py:26:1: F821 undefined name 'orm'
./invoice.py:27:1: W191 indentation contains tabs
./invoice.py:29:1: W191 indentation contains tabs
./invoice.py:30:1: W191 indentation contains tabs
./invoice.py:30:3: E126 continuation line over-indented for hanging indent
./invoice.py:30:76: W291 trailing whitespace
./invoice.py:31:1: W191 indentation contains tabs
./invoice.py:31:4: E128 continuation line under-indented for visual indent
./invoice.py:31:80: E501 line too long (89 > 79 characters)
./invoice.py:32:1: W191 indentation contains tabs
./invoice.py:32:4: E126 continuation line over-indented for hanging indent
./invoice.py:33:1: W191 indentation contains tabs
./sale.py:23:1: F401 'fields' imported but unused
./sale.py:23:1: F401 'osv' imported but unused
./sale.py:23:23: E231 missing whitespace after ','
./sale.py:24:1: F401 '_' imported but unused
./sale.py:26:1: E302 expected 2 blank lines, found 1
./sale.py:26:1: F821 undefined name 'orm'
./sale.py:27:1: W191 indentation contains tabs
./sale.py:28:1: E101 indentation contains mixed spaces and tabs
./sale.py:28:1: W293 blank line contains whitespace
./sale.py:29:1: W191 indentation contains tabs
./sale.py:31:1: W191 indentation contains tabs
./sale.py:31:80: E501 line too long (88 > 79 characters)
./sale.py:32:1: W191 indentation contains tabs
./sale.py:33:1: W191 indentation contains tabs
./sale.py:33:6: E126 continuation line over-indented for hanging indent
./sale.py:34:1: W191 indentation contains tabs
./sale.py:34:6: E126 continuation line over-indented for hanging indent
./sale.py:35:1: W191 indentation contains tabs

review: Needs Fixing

« Back to merge proposal