Merge lp:~schwann/qtubuntu-camera/camera-click-sound into lp:qtubuntu-camera

Proposed by Günter Schwann
Status: Merged
Approved by: Günter Schwann
Approved revision: 85
Merged at revision: 84
Proposed branch: lp:~schwann/qtubuntu-camera/camera-click-sound
Merge into: lp:qtubuntu-camera
Diff against target: 57 lines (+8/-1)
2 files modified
src/aalimagecapturecontrol.cpp (+6/-1)
src/aalimagecapturecontrol.h (+2/-0)
To merge this branch: bzr merge lp:~schwann/qtubuntu-camera/camera-click-sound
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Thomas Moenicke (community) Approve
Review via email: mp+185989@code.launchpad.net

Commit message

Play sound when capturing a photo fixes LP: #1220736

Description of the change

Play sound when capturing a photo fixes LP: #1220736

To post a comment you must log in.
Revision history for this message
Thomas Moenicke (thomas-moenicke) wrote :

maybe delete it in destructor

85. By Günter Schwann

Explicitly delete the m_audioPlayer object

Revision history for this message
Thomas Moenicke (thomas-moenicke) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/aalimagecapturecontrol.cpp'
--- src/aalimagecapturecontrol.cpp 2013-06-24 07:00:43 +0000
+++ src/aalimagecapturecontrol.cpp 2013-09-17 09:30:23 +0000
@@ -27,6 +27,7 @@
27#include <QDir>27#include <QDir>
28#include <QFile>28#include <QFile>
29#include <QFileInfo>29#include <QFileInfo>
30#include <QMediaPlayer>
30#include <QStandardPaths>31#include <QStandardPaths>
31#include <QTemporaryFile>32#include <QTemporaryFile>
3233
@@ -44,13 +45,16 @@
44 m_photoWidth(320),45 m_photoWidth(320),
45 m_photoHeight(240),46 m_photoHeight(240),
46 m_aspectRatio(0.0),47 m_aspectRatio(0.0),
47 m_screenAspectRatio(0.0)48 m_screenAspectRatio(0.0),
49 m_audioPlayer(new QMediaPlayer(this))
48{50{
49 m_galleryPath = QStandardPaths::writableLocation(QStandardPaths::PicturesLocation);51 m_galleryPath = QStandardPaths::writableLocation(QStandardPaths::PicturesLocation);
52 m_audioPlayer->setMedia(QUrl::fromLocalFile("/system/media/audio/ui/camera_click.ogg"));
50}53}
5154
52AalImageCaptureControl::~AalImageCaptureControl()55AalImageCaptureControl::~AalImageCaptureControl()
53{56{
57 delete(m_audioPlayer);
54}58}
5559
56bool AalImageCaptureControl::isReadyForCapture() const60bool AalImageCaptureControl::isReadyForCapture() const
@@ -157,6 +161,7 @@
157161
158void AalImageCaptureControl::shutter()162void AalImageCaptureControl::shutter()
159{163{
164 m_audioPlayer->play();
160 Q_EMIT imageExposed(m_lastRequestId);165 Q_EMIT imageExposed(m_lastRequestId);
161}166}
162167
163168
=== modified file 'src/aalimagecapturecontrol.h'
--- src/aalimagecapturecontrol.h 2013-06-24 07:00:43 +0000
+++ src/aalimagecapturecontrol.h 2013-09-17 09:30:23 +0000
@@ -27,6 +27,7 @@
27class AalCameraControl;27class AalCameraControl;
28class CameraControl;28class CameraControl;
29class CameraControlListener;29class CameraControlListener;
30class QMediaPlayer;
3031
31class AalImageCaptureControl : public QCameraImageCaptureControl32class AalImageCaptureControl : public QCameraImageCaptureControl
32{33{
@@ -81,6 +82,7 @@
81 /// currently selected camera82 /// currently selected camera
82 QList<float> m_prioritizedAspectRatios;83 QList<float> m_prioritizedAspectRatios;
83 QString m_galleryPath;84 QString m_galleryPath;
85 QMediaPlayer *m_audioPlayer;
84};86};
8587
86#endif88#endif

Subscribers

People subscribed via source and target branches