gallery-app

Code review comment for lp:~schwann/gallery-app/gallery-uitk-emulators

  1. gallery-uitk-emulators
  2. Merge into trunk
Revision history for this message
Olivier Tilloy (osomon) wrote :

Output of pyflakes on this branch:

tests/autopilot/gallery_app/tests/test_photos_view.py:104: local variable 'delete_dialog' is assigned to but never used
tests/autopilot/gallery_app/tests/test_events_view.py:19: 'sleep' imported but unused
tests/autopilot/gallery_app/tests/test_events_view.py:89: local variable 'delete_dialog' is assigned to but never used
tests/autopilot/gallery_app/tests/__init__.py:20: 'main_screen' imported but unused
tests/autopilot/gallery_app/tests/test_photo_viewer.py:102: local variable 'delete_dialog' is assigned to but never used
tests/autopilot/gallery_app/tests/test_picker_mode.py:19: 'exists' imported but unused
tests/autopilot/gallery_app/tests/test_picker_mode.py:20: 'sleep' imported but unused

Not all of those warnings were introduced by changes in this branch, but at least a couple of them were, so they should be addressed. And if you choose to address them all here, I won’t mind.

review: Needs Fixing

« Back to merge proposal