Code review comment for lp:~schwann/gallery-app/gallery-remove-directory-includes

Revision history for this message
Olivier Tilloy (osomon) wrote :

> > 44 + ${gallery_src_SOURCE_DIR}/database
> > 45 + ${gallery_src_SOURCE_DIR}/media
> > 46 + ${gallery_src_SOURCE_DIR}/photo
> > 47 + ${gallery_src_SOURCE_DIR}/qml
> >
> > Shouldn’t this be:
> >
> > ${gallery_database_src_SOURCE_DIR}
> > ${gallery_media_src_SOURCE_DIR}
> > ${gallery_photo_src_SOURCE_DIR}
> > ${gallery_qml_src_SOURCE_DIR}
>
> I had this before. But I had to do this because of the cmake issues with
> circular dependencies

Ouch :(
Can you please add a comment there to explain?

« Back to merge proposal