Merge lp:~schwann/gallery-app/gallery-orientation-suppot into lp:gallery-app

Proposed by Günter Schwann
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 670
Merged at revision: 673
Proposed branch: lp:~schwann/gallery-app/gallery-orientation-suppot
Merge into: lp:gallery-app
Diff against target: 24 lines (+3/-0)
2 files modified
rc/qml/GalleryApplication.qml (+2/-0)
rc/qml/MainScreen.qml (+1/-0)
To merge this branch: bzr merge lp:~schwann/gallery-app/gallery-orientation-suppot
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+164314@code.launchpad.net

Commit message

Support orientation change

Description of the change

Support orientation change, by enabling the SDK automaticOrientation support

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
670. By Günter Schwann

Merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

Overall works well (tested on Galaxy Nexus).

One thing that doesn’t work as well as it should is rotating the screen while cropping an image. But it can be addressed separately. Can you please file a bug report to track the issue, once this branch has been merged?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'rc/qml/GalleryApplication.qml'
--- rc/qml/GalleryApplication.qml 2013-05-22 18:35:58 +0000
+++ rc/qml/GalleryApplication.qml 2013-05-24 07:23:28 +0000
@@ -35,6 +35,8 @@
35 */35 */
36 property bool isPortrait: (height > width)36 property bool isPortrait: (height > width)
3737
38 property bool automaticOrientation: true
39
38 // Big list of form factor-specific values. 'default' is used if the key40 // Big list of form factor-specific values. 'default' is used if the key
39 // can't be found under any other form_factor (otherwise, form_factors should41 // can't be found under any other form_factor (otherwise, form_factors should
40 // match the FORM_FACTOR values passed from main.cpp). Just add Portrait to42 // match the FORM_FACTOR values passed from main.cpp). Just add Portrait to
4143
=== modified file 'rc/qml/MainScreen.qml'
--- rc/qml/MainScreen.qml 2013-05-22 17:29:50 +0000
+++ rc/qml/MainScreen.qml 2013-05-24 07:23:28 +0000
@@ -31,6 +31,7 @@
3131
32 anchors.fill: parent32 anchors.fill: parent
33 applicationName: "gallery-app"33 applicationName: "gallery-app"
34 automaticOrientation: application.automaticOrientation
3435
35 Tabs {36 Tabs {
36 id: tabs37 id: tabs

Subscribers

People subscribed via source and target branches