Merge lp:~schwann/gallery-app/gallery-delete-album into lp:gallery-app

Proposed by Günter Schwann
Status: Merged
Approved by: Günter Schwann
Approved revision: 840
Merged at revision: 841
Proposed branch: lp:~schwann/gallery-app/gallery-delete-album
Merge into: lp:gallery-app
Diff against target: 75 lines (+18/-6)
2 files modified
rc/qml/AlbumViewer/AlbumViewer.qml (+11/-6)
rc/qml/AlbumViewer/AlbumViewerAnimated.qml (+7/-0)
To merge this branch: bzr merge lp:~schwann/gallery-app/gallery-delete-album
Reviewer Review Type Date Requested Status
Thomas Moenicke (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+186309@code.launchpad.net

Commit message

Enable delete in album view (close view without animation) fixes LP: #1163437

Description of the change

Enable delete in album view (close view without animation) fixes LP: #1163437

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Thomas Moenicke (thomas-moenicke) wrote :

looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'rc/qml/AlbumViewer/AlbumViewer.qml'
--- rc/qml/AlbumViewer/AlbumViewer.qml 2013-08-16 12:55:55 +0000
+++ rc/qml/AlbumViewer/AlbumViewer.qml 2013-09-18 12:48:12 +0000
@@ -54,6 +54,8 @@
5454
55 // When the user clicks the back button or pages back to the cover.55 // When the user clicks the back button or pages back to the cover.
56 signal closeRequested(bool stayOpen, int viewingPage)56 signal closeRequested(bool stayOpen, int viewingPage)
57 // When the user clicks the back button or pages back to the cover.
58 signal quickCloseRequested()
5759
58 Image {60 Image {
59 anchors.fill: parent61 anchors.fill: parent
@@ -74,6 +76,11 @@
74 closeRequested(album.containedCount > 0, albumSpreadViewer.viewingPage)76 closeRequested(album.containedCount > 0, albumSpreadViewer.viewingPage)
75 }77 }
7678
79 /// Closes the view without animation or storing anything
80 function __quickClose() {
81 quickCloseRequested()
82 }
83
77 FadeOutAnimation {84 FadeOutAnimation {
78 id: fadeOutAnimation85 id: fadeOutAnimation
7986
@@ -374,12 +381,10 @@
374 id: albumTrashDialog381 id: albumTrashDialog
375 visible: false382 visible: false
376 onDeleteClicked: {383 onDeleteClicked: {
377 // FIXME do not show the close animation384 __quickClose();
378 __close()
379 }385 }
380 onDeleteWithContentsClicked: {386 onDeleteWithContentsClicked: {
381 // FIXME do not show the close animation387 __quickClose();
382 __close()
383 }388 }
384 }389 }
385390
@@ -397,15 +402,15 @@
397 text: i18n.tr("Add") // text in toolbar402 text: i18n.tr("Add") // text in toolbar
398 }403 }
399 ToolbarButton {404 ToolbarButton {
405 id: deleteButton
400 objectName: "deleteButton"406 objectName: "deleteButton"
401 text: i18n.tr("Delete")407 text: i18n.tr("Delete")
402 iconSource: Qt.resolvedUrl("../../img/delete.png")408 iconSource: Qt.resolvedUrl("../../img/delete.png")
403 onTriggered: {409 onTriggered: {
404 albumTrashDialog.album = album410 albumTrashDialog.album = album
405 albumTrashDialog.caller = caller411 albumTrashDialog.caller = deleteButton
406 albumTrashDialog.show()412 albumTrashDialog.show()
407 }413 }
408 enabled: false // FIXME enable once the close animation is not shown anymore
409 }414 }
410 back: ToolbarButton {415 back: ToolbarButton {
411 text: i18n.tr("Back")416 text: i18n.tr("Back")
412417
=== modified file 'rc/qml/AlbumViewer/AlbumViewerAnimated.qml'
--- rc/qml/AlbumViewer/AlbumViewerAnimated.qml 2013-06-20 11:54:49 +0000
+++ rc/qml/AlbumViewer/AlbumViewerAnimated.qml 2013-09-18 12:48:12 +0000
@@ -87,6 +87,13 @@
87 inner_albumViewer.visible = false87 inner_albumViewer.visible = false
88 isOpen = false88 isOpen = false
89 }89 }
90 onQuickCloseRequested: {
91 inner_albumViewer.visible = false
92 isOpen = false
93 if (previewItem)
94 previewItem.visible = true;
95 loader_albumViewer.unload();
96 }
90 }97 }
9198
92 AlbumViewerTransition {99 AlbumViewerTransition {

Subscribers

People subscribed via source and target branches