Code review comment for lp:~schnetter/pocl/pocl

clEnqueueCopyImageToBuffer.c and scripts/pocl-build.in have bzr conflict markers.

Why do you use TARGET instead of HOST_CPU in the pthread driver? I think HOST_CPU is more descriptive as pthread/basic are supposed to be always driver for the same CPU as the host (and share memory with it).

What is the POCL_ALIAS_OPENCL_SYMBOL change? Is the attribute 'alias' portable or is it gcc-only? Can you add a comment to the file where it's defined of its purpose?

About the comment in scripts/pocl-workgroup.in where you wonder the bitcode triplet incompatibility warning when linking bitcodes: This is a regression if the warning is again there. There used to be a detection of what is the host cpu's target triplet and it used it instead of the hard coded one when building the host cpu's kernel library. E.g. x86_64 was then build with your OSx triplet. It was just because of this, to make the warning go away -- and who knows if a kernel lib compiled with an inaccurate triplet has other more serious implications later on.