Code review comment for lp:~schnetter/pocl/main

Revision history for this message
Carlos Sánchez de La Lama (csanchezdll) wrote :

Hi Erik,

in the select() it is clear both doubles are long are required (the prototype is
double select(double, double, long)
so it could not be otherwise). However, some calls require only doubles (for example, bitselect, all the trigonometric functions for double, ...) and those can be there even if the machine does not support 64-bit integers (longs).

Look for example at sin.cl; it is using BUILTIN_V_V template, and when I added the macros I changed the template so double versions are only defined if cl_khr_fp64 is defined. But AFAIU there is no real dependency with long there (please correct me if I am mistaken) so this should be done regardless of the cl_khr_int64 status.

BR

Carlos

« Back to merge proposal