Ubuntu
proguard package

Code review comment for lp:~scarneiro/ubuntu/quantal/proguard/fix-for-888982

  1. Quantal (12.10)
  2. fix-for-888982
  3. Merge into quantal
Revision history for this message
James Page (james-page) wrote :

Hi Sebastian

Thanks for taking the time to prepare this merge proposal.

I have uploaded with a couple of minor tweaks:

1) You don't need to Depend on build-essential - this is actually a lintian error - I would recommend that you always run lintian both on your source package and the resulting binary package to check for any errors that it can pickup.

See http://lintian.debian.org/manual/index.html for more info.

2) debian/pathes/debian-changes-4.8: this is an auto-generated patch due to the switch in the previous version from source format 1.0 to source format 3.0 - you can read more about these formats here - http://wiki.debian.org/Projects/DebSrc3.0

I renamed the patch and tweaked the headers (as they refer to the upgrade bug which does not make much sense) so things don't get confused later - this should be fed back to Debian but the maintainer is not that active (i.e. leave it with me - I'll need to deal with this for the next Debian release anyway).

Thanks for you contribution!

review: Approve

« Back to merge proposal