Merge lp:~scarneiro/ubuntu/oneiric/stereograph/fix-for-755934 into lp:ubuntu/oneiric/stereograph

Proposed by Sebastian Carneiro
Status: Merged
Merged at revision: 5
Proposed branch: lp:~scarneiro/ubuntu/oneiric/stereograph/fix-for-755934
Merge into: lp:ubuntu/oneiric/stereograph
Diff against target: 63 lines (+19/-3)
4 files modified
Makefile (+1/-1)
Makefile.in (+2/-0)
debian/changelog (+13/-0)
debian/control (+3/-2)
To merge this branch: bzr merge lp:~scarneiro/ubuntu/oneiric/stereograph/fix-for-755934
Reviewer Review Type Date Requested Status
Marc Deslauriers Approve
Ubuntu branches Pending
Review via email: mp+69448@code.launchpad.net

Description of the change

Updated library for libpng, changed Makefile to eliminate hardcoded library paths, and added target to fix FTBFS with ld --no-add-needed.-

Thanks.

To post a comment you must log in.
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Looks good, ACK. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile'
--- Makefile 2004-04-25 15:45:50 +0000
+++ Makefile 2011-07-27 12:38:20 +0000
@@ -17,7 +17,7 @@
17else17else
18CFLAGS += -O218CFLAGS += -O2
19endif19endif
20LDFLAGS = -lm /usr/lib/libpng.so /usr/lib/libz.so20LDFLAGS = -lm -lpng -lz
2121
22# HPUX22# HPUX
23#CC = cc23#CC = cc
2424
=== modified file 'Makefile.in'
--- Makefile.in 2004-04-25 15:45:50 +0000
+++ Makefile.in 2011-07-27 12:38:20 +0000
@@ -8,6 +8,8 @@
8make: all8make: all
99
10stereograph: $(OBJ0)10stereograph: $(OBJ0)
11 gcc -g -o $@ $(OBJ0) $(LDFLAGS)
12
11stereograph.o: stereograph.c stereograph.h renderer.h gfxio.h globals.h13stereograph.o: stereograph.c stereograph.h renderer.h gfxio.h globals.h
12renderer.o: renderer.c renderer.h globals.h14renderer.o: renderer.c renderer.h globals.h
13gfxio.o: gfxio.c gfxio.h renderer.h globals.h15gfxio.o: gfxio.c gfxio.h renderer.h globals.h
1416
=== modified file 'debian/changelog'
--- debian/changelog 2005-10-10 02:38:01 +0000
+++ debian/changelog 2011-07-27 12:38:20 +0000
@@ -1,3 +1,16 @@
1stereograph (0.30a-6ubuntu1) oneiric; urgency=low
2
3 * Changed library references, changed and updated parameters
4 to linker to solve FTBFS (LP: #755934):
5 - Makefile: replaced hardcoded libraries with library
6 parameters for libpng and libz.
7 - Makefile.in: added target to build stereograph executable
8 putting the library references after the objects that
9 needs them, to build with ld --no-as-needed.
10 - debian/control: updated build depends for libpng.
11
12 -- Sebastian Carneiro <scarneiro@fibertel.com.ar> Wed, 27 Jul 2011 09:18:43 -0300
13
1stereograph (0.30a-6) unstable; urgency=low14stereograph (0.30a-6) unstable; urgency=low
215
3 * Build-Depend on libpng-dev instead of libpng2-dev (closes: #328340).16 * Build-Depend on libpng-dev instead of libpng2-dev (closes: #328340).
417
=== modified file 'debian/control'
--- debian/control 2005-10-10 02:38:01 +0000
+++ debian/control 2011-07-27 12:38:20 +0000
@@ -1,9 +1,10 @@
1Source: stereograph1Source: stereograph
2Section: graphics2Section: graphics
3Priority: optional3Priority: optional
4Maintainer: Peter Palfrader <weasel@debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Peter Palfrader <weasel@debian.org>
5Standards-Version: 3.6.26Standards-Version: 3.6.2
6Build-Depends: libpng-dev, debhelper, zlib1g-dev7Build-Depends: libpng12-dev, debhelper, zlib1g-dev
78
8Package: stereograph9Package: stereograph
9Architecture: any10Architecture: any

Subscribers

People subscribed via source and target branches