Merge ~sbparke/charm-juju-lint:bug/1950983 into charm-juju-lint:master

[Steven Parker]

Now passing ca-cert as ascii format as it is really binary and trying to parse as UTF-8 will be unstable/unreliable

ca-cert is really binary and trying to parse as UTF-8 will be unstable/unreliable
Best to simply pass on as ascii base64 encoded value.
I have modified the code and tested just passing the ascii configuration value and this works fine.

b64decode(auto_lint_config["controller-cacert"]).decode() -> cacert = auto_lint_config["controller-cacert"]

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

A CI job is currently in progress. A follow up comment will be added when it completes.

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

FAILED: Continuous integration, rev:7a8df02a4e1448fd252394ba58a59f1d3872d543
https://jenkins.canonical.com/bootstack/job/lp-charm-juju-lint-ci/1/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/216/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/661/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-juju-lint-ci/1//rebuild

review: Needs Fixing (continuous-integration)

[Steven Parker (sbparke)]

This is in response to BUG https://bugs.launchpad.net/charm-juju-lint/+bug/1950983

a286bb5... by Steven Parker on 2021-11-17

Fixed style errors

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

A CI job is currently in progress. A follow up comment will be added when it completes.

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

FAILED: Continuous integration, rev:a286bb55742e896168f5a8217cdbd0696f3251f1
https://jenkins.canonical.com/bootstack/job/lp-charm-juju-lint-ci/2/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/222/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/668/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-juju-lint-ci/2//rebuild

review: Needs Fixing (continuous-integration)

Unmerged commits

a286bb5... by Steven Parker on 2021-11-17

Fixed style errors

7a8df02... by Steven Parker on 2021-11-15

Now passing ca-cert as ascii format as it is really binary and trying to parse as UTF-8 will be unstable/unreliable

diff --git a/scripts/templates/auto_lint.py b/scripts/templates/auto_lint.py
index 4b8da76..d84f05e 100755
--- a/scripts/templates/auto_lint.py
+++ b/scripts/templates/auto_lint.py
@@ -20,7 +20,6 @@ License: Apache License 2.0
 """
 
 import argparse
-from base64 import b64decode
 import json
 import logging
 from os.path import join
@@ -74,9 +73,10 @@ def verify_auto_lint_config(auto_lint_config):
 async def get_juju_status(auto_lint_config):
     """Get juju status."""
     model = Model(max_frame_size=MAX_FRAME_SIZE)
-    # As b64decode returns bytes instead of str, we need to convert it
-    # using .decode() on the bytes object.
-    cacert = b64decode(auto_lint_config["controller-cacert"]).decode()
+
+    # sbparke modified this logic to just send raw ascii formatted cert
+    #  due to transcoding failure as data is not always valid utf8
+    cacert = auto_lint_config["controller-cacert"]
     await model.connect(
         endpoint=auto_lint_config["controller-endpoint"],
         username=auto_lint_config["controller-username"],