Merge ~sbparke/charm-juju-lint:bug/1950983 into charm-juju-lint:master
Proposed by
Steven Parker
Status: | Rejected |
---|---|
Rejected by: | Haw Loeung |
Proposed branch: | ~sbparke/charm-juju-lint:bug/1950983 |
Merge into: | charm-juju-lint:master |
Diff against target: |
26 lines (+4/-4) 1 file modified
scripts/templates/auto_lint.py (+4/-4) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
🤖 prod-jenkaas-bootstack (community) | continuous-integration | Needs Fixing | |
BootStack Reviewers | mr tracking; do not claim | Pending | |
BootStack Reviewers | Pending | ||
BootStack Reviewers | Pending | ||
Review via email: mp+411888@code.launchpad.net |
Commit message
Now passing ca-cert as ascii format as it is really binary and trying to parse as UTF-8 will be unstable/unreliable
Description of the change
ca-cert is really binary and trying to parse as UTF-8 will be unstable/unreliable
Best to simply pass on as ascii base64 encoded value.
I have modified the code and tested just passing the ascii configuration value and this works fine.
b64decode(
To post a comment you must log in.
This merge proposal is being monitored by mergebot. Change the status to Approved to merge.