Code review comment for lp:~sbi/openobject-addons/trunk-sbi-timesheet-checks-as-su
Revision history for this message
| Stéphane Bidoul (Acsone) (sbi) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Hi Fabien,
On Wed, Nov 14, 2012 at 1:33 PM, Fabien (Open ERP) <email address hidden> wrote:
> Review: Disapprove
>
> We try to limit the usage of SUPERUSER_ID only for secific cases where
> it's required.
> I prefer to reject this one as it's not very important added feature.
I fully understand we want to limit usage of SUPERUSER_ID.
However in general, checks and invariant have to be satisfied independently
of the permissions of the user doing the operations.
In this specifc case, doing these checks under the user's identity require
granting the user unnessary rights.
-sbi