Merge lp:~sbi/c2c-addons/6.1-bug1071199 into lp:c2c-addons/6.1

[Stéphane Bidoul (Acsone)]

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Hello,

That seems correct to me, just one detail, we could reduce the number of write on the tasks to one call instead of a call per task.
But that's a very small optimisation as we will probably rarely change the project on a bunch of tasks.

Thanks

review: Approve

[Stéphane Bidoul (Acsone) (sbi)]

Hi Guewen,

I'd think this optimization is not worth the effort :)

-sbi

On Tue, Oct 30, 2012 at 10:52 AM, Guewen Baconnier @ Camptocamp <
<email address hidden>> wrote:

> Review: Approve
>
> Hello,
>
> That seems correct to me, just one detail, we could reduce the number of
> write on the tasks to one call instead of a call per task.
> But that's a very small optimisation as we will probably rarely change the
> project on a bunch of tasks.
>
> Thanks
> --
> https://code.launchpad.net/~sbi/c2c-addons/6.1-bug1071199/+merge/131607
> You are the owner of lp:~sbi/c2c-addons/6.1-bug1071199.
>

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Your fix is merged in 6.1 and 7.0 branches.

Thanks Stéphane for your involvement.

Guewen

=== modified file 'timesheet_task/project_task.py'
--- timesheet_task/project_task.py	2012-10-15 15:22:12 +0000
+++ timesheet_task/project_task.py	2012-10-26 13:03:29 +0000
@@ -87,6 +87,17 @@
                                      help="Percent of tasks closed according to the total of tasks todo.",
                                      store = {'project.task': (lambda self, cr, uid, ids, c={}: ids, TASK_WATCHERS, 20),
                                               'account.analytic.line': (_get_analytic_line, AA_WATCHERS, 20)})}
+    
+    def write(self, cr, uid, ids, vals, context=None):
+        res = super(ProjectTask, self).write(cr, uid, ids, vals, context=context)
+        if 'project_id' in vals:
+            ts_obj = self.pool.get('hr.analytic.timesheet')
+            project_obj = self.pool.get('project.project')
+            project = project_obj.browse(cr, uid, vals['project_id'], context)
+            account_id = project.analytic_account_id.id
+            for task in self.browse(cr, uid, ids, context=context):
+                ts_obj.write(cr, uid, [w.id for w in task.work_ids], {'account_id': account_id}, context=context)
+        return res
 
 ProjectTask()