Merge lp:~sbi/account-financial-report/account-financial-report-v7bug20130410 into lp:account-financial-report/trunk

[Stéphane Bidoul (Acsone)]

Fix account_financial_report_webkit for v7 compatibility with account_move_line form view:
- separator string="Internal Note" does not exist anymore in stock view
- move the last_rec_date field to the reconcilation group

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

LGTM

review: Approve (code review, no test)

[Stefan Rijnhart (Opener) (stefan-opener)]

The account module refers to the move line's reconciliation fields in the following view:

view_move_line_form
view_move_line_form2
view_move_form

This module only adds the field to the form. Would it be a good idea to take the opportunity to add the last_rec_date field to the other views as well in this merge proposal?

review: Needs Information

[Stéphane Bidoul (Acsone) (sbi)]

view_move_line_form is covered already.
I'm not sure about the purpose view_move_line_form2?

The original author might comment on this one better than I could.

With this MP, I only intended to restore compatibility with v7.

-sbi

On Mon, Apr 29, 2013 at 10:39 AM, Stefan Rijnhart (Therp)
<email address hidden>wrote:

> Review: Needs Information
>
> The account module refers to the move line's reconciliation fields in the
> following view:
>
> view_move_line_form
> view_move_line_form2
> view_move_form
>
> This module only adds the field to the form. Would it be a good idea to
> take the opportunity to add the last_rec_date field to the other views as
> well in this merge proposal?
>
> --
>
> https://code.launchpad.net/~sbi/account-financial-report/account-financial-report-v7bug20130410/+merge/158031
> You are the owner of
> lp:~sbi/account-financial-report/account-financial-report-v7bug20130410.
>

[Stefan Rijnhart (Opener) (stefan-opener)]

Yes, the change below covers 'view_move_line_form'. That leaves 'view_move_line_form2' which is only referred to in account_analytic_plans/account_analytic_plans_view.xml (but still, for completeness sake it could be covered) and 'view_move_form' which is referred to in various places.

[lp:~sbi/account-financial-report/account-financial-report-v7bug20130410]

27. By Stéphane Bidoul (Acsone) on 2013-05-02

[IMP] add last_rec_date in other forms for completeness

[Stéphane Bidoul (Acsone) (sbi)]

I've updated the other forms for completeness as suggested by Stefan.

BTW, in view_move_form, how can one show the form view of the move lines in web v7?

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks for adding the extra views! Hope that C2C agrees with that suggestion of mine.

As for your question, you cannot switch from tree to form view anymore in a one2many widget in OpenERP 7.

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Yes, we agree that's fine, thanks Stéphane and Stefan!

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Hi,

I was about to merge revno 26 / revid. <email address hidden>
from lp:account-financial-report/trunk to lp:account-financial-report/7.0 when I noticed that the last_rec_date field is no longer displayed at all in the views in the 7.0 version.

I asked our functional guy who thinks that the field is not worth to be displayed and does not bring useful information for the users.

Do you agree or do you see a reason to keep the field in the views?

Thanks

[Stéphane Bidoul (Acsone) (sbi)]

Hi,

The purpose of revno 26 was to fix the views for 7.0 (ie fix the display of
last_rec_date).
Why do you say it's no longer displayed?

Anyway, we don't use last_rec_date so if you believe it's not necessary,
you can drop it from the views.

-sbi

On Tue, May 7, 2013 at 10:53 AM, Guewen Baconnier @ Camptocamp <
<email address hidden>> wrote:

> Hi,
>
> I was about to merge revno 26 / revid.
> <email address hidden>
> from lp:account-financial-report/trunk to lp:account-financial-report/7.0
> when I noticed that the last_rec_date field is no longer displayed at all
> in the views in the 7.0 version.
>
> I asked our functional guy who thinks that the field is not worth to be
> displayed and does not bring useful information for the users.
>
> Do you agree or do you see a reason to keep the field in the views?
>
> Thanks
> --
>
> https://code.launchpad.net/~sbi/account-financial-report/account-financial-report-v7bug20130410/+merge/158031
> You are the owner of
> lp:~sbi/account-financial-report/account-financial-report-v7bug20130410.
>

[Stefan Rijnhart (Opener) (stefan-opener)]

No objections to removing the field from the views here.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Ok, fine.

Stéphane, the branch lp:account-financial-report/7.0 is more recent than lp:account-financial-report/trunk and in the former this field was dropped from the views. I think that the version in the trunk branch is the 6.1 one before we migrated it to the version 7.0

Thanks!

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

By the way, I apologize for not having noticed this before.

[Stéphane Bidoul (Acsone) (sbi)]

No probl. I also had some doubt had some point but did not notice either.

On Tue, May 7, 2013 at 11:48 AM, Guewen Baconnier @ Camptocamp <
<email address hidden>> wrote:

> By the way, I apologize for not having noticed this before.
> --
>
> https://code.launchpad.net/~sbi/account-financial-report/account-financial-report-v7bug20130410/+merge/158031
> You are the owner of
> lp:~sbi/account-financial-report/account-financial-report-v7bug20130410.
>

=== modified file 'account_financial_report_webkit/account_move_line_view.xml'
--- account_financial_report_webkit/account_move_line_view.xml	2012-04-16 16:02:14 +0000
+++ account_financial_report_webkit/account_move_line_view.xml	2013-05-02 17:23:50 +0000
@@ -10,13 +10,37 @@
             <!-- modulename.view -->
             <field name="type">form</field>
             <field name="arch" type="xml">
-                <separator string="Internal Note" colspan="4" position="before">
-                    <separator string="Misc."/>
-                    <newline/>
-                    <group>
-                        <field name="last_rec_date" readonly="1"/>
-                    </group>
-                </separator>
+                <field name="reconcile_partial_id" position="after">
+                    <field name="last_rec_date" readonly="1"/>
+                </field>
+            </field>
+        </record>
+        <record model="ir.ui.view" id="last_rec_date_form2">
+            <!-- must be unique in this module. -->
+            <field name="name">last_rec_date_form2</field>
+            <field name="model">account.move.line</field>
+            <!--parent python entity -->
+            <field name="inherit_id" ref="account.view_move_line_form2"/>
+            <!-- modulename.view -->
+            <field name="type">form</field>
+            <field name="arch" type="xml">
+                <field name="reconcile_partial_id" position="after">
+                    <field name="last_rec_date" readonly="1"/>
+                </field>
+            </field>
+        </record>
+        <record model="ir.ui.view" id="last_rec_date_move_form">
+            <!-- must be unique in this module. -->
+            <field name="name">last_rec_date_move_form</field>
+            <field name="model">account.move</field>
+            <!--parent python entity -->
+            <field name="inherit_id" ref="account.view_move_form"/>
+            <!-- modulename.view -->
+            <field name="type">form</field>
+            <field name="arch" type="xml">
+                <field name="reconcile_partial_id" position="after">
+                    <field name="last_rec_date" readonly="1"/>
+                </field>
             </field>
         </record>
     </data>