Code review comment for lp:~sberg-l/charms/trusty/nova-compute/next

Revision history for this message
Skyler Berg (sberg-l) wrote :

Thanks for the feedback, Ryan!

nfs_mount_options was added to the [libvirt] section of nova.conf in Icehouse and has continued to exist in the all subsequent releases. As such, I added to the templates for all Icehouse, Juno, and Kilo.

I do not need any additional options other than nfs_mount_options.

As for other changes, I do not anticipate any. This change should be isolated. Soon I will be uploading my cinder-tintri charm. In that charm's README I will instruct users to set this option appropriately. However, the code in my charm will not touch nova-compute at all.

« Back to merge proposal