Code review comment for ~sbeattie/qa-regression-testing:moar-ci-tests

Revision history for this message
Alex Murray (alexmurray) wrote :

Thanks Steve, this looks awesome - I would have hoped that setting the variable inside the .launchpad.yaml would then mean that lpci would also set it when running locally - however, this would also mean we would have to duplicate that into every job entry in the yaml as well - so setting it in lpcraft-runner means we only have to put it in one place.

So FWIW I think your current approach is great.

review: Approve

« Back to merge proposal