I think other thing to consider is where tests have been changed to be ethernet specific. On real hardware where wifi is supported (e.g. dragonboard), the ethernet indicator would be replaced by the wifi indicator. So can we make the tests more generic? e.g. test_ethernet_settings_item_open_correct_page changes to test_network_settings_item_open_correct_page, and then open the relevant indicator based on whether wifi of ethernet is supported.
Although the tests are passing, I'm seeing this import error during the test log: http:// pastebin. ubuntu. com/24223453/
I think other thing to consider is where tests have been changed to be ethernet specific. On real hardware where wifi is supported (e.g. dragonboard), the ethernet indicator would be replaced by the wifi indicator. So can we make the tests more generic? e.g. test_ethernet_ settings_ item_open_ correct_ page changes to test_network_ settings_ item_open_ correct_ page, and then open the relevant indicator based on whether wifi of ethernet is supported.
Some other comments below.