Code review comment for ~sbaldassin/bileto:ust-bileto

Revision history for this message
Santiago Baldassin (sbaldassin) wrote :

> Sorry, another question: Are you saying it's possible to trigger UST with an
> ajax request? Or is the ajax request only for querying the status after it's
> been triggered?
>
> If the former, I'd strongly prefer that over importing this qakit module,
> which imports jenkins module. Even when we used jenkins extensively, bileto
> only ever spoke JSON to it, I never had to import jenkins module, so I'd
> prefer not to start using that now if it can be helped.

I was thinking about an ajax request to get the results. About importing qakit, I'd like to keep it if you guys don't mind. Please take into account that qakit is not only talking to Jenkins but also to practitest and to launchpad. The beauty of using the jenkins lib is that you forget about dealing with http requests, catching errors, packing/unpacking requests and results, etc. By the way, the jenkins module is a well known and widely use module, so I'm not sure why we should not use it, that said, If there's any technical roadblock related to it, I'm open to change it

« Back to merge proposal