Code review comment for ~sbaldassin/bileto:ust-bileto

Revision history for this message
Santiago Baldassin (sbaldassin) wrote :

Thanks for your feedback Robert. I'll be working on your comments. In the meantime, here's the code for qakit: https://code.launchpad.net/qakit.

About triggering this from Britney during proposed migration, we would just need to re-use the code that I've added in bileto or we could just publish an amqp message (containing the ppa) to /ubuntu-system-tests. What we have to consider is that we want to avoid a message to be publish for every single package in ppa. From what I understood when I took a look at britney, a different amqp message is published for every single source package in the ppa and we need a single message for the whole ppa. The current worker is already listening amqp so I can give you a hand to test this if you want

Last but not least, I'd like to keep the reporting in bileto if you don't mind since it will help us to trace the results easily to our jenkins builds. Polling for results will generate a single http request which response is a 100 bytes message so the performance degradation in bileto should be minimum and I also make sure that if no response is received then an empty response is returned so that angularjs can parse it in any case

« Back to merge proposal