Merge lp:~savoirfairelinux-openerp/openupgrade-server/AttributeErrorFix into lp:openupgrade-server

Status: Merged
Merged at revision: 4639
Proposed branch: lp:~savoirfairelinux-openerp/openupgrade-server/AttributeErrorFix
Merge into: lp:openupgrade-server
Diff against target: 12 lines (+1/-1)
1 file modified
openerp/openupgrade/openupgrade.py (+1/-1)
To merge this branch: bzr merge lp:~savoirfairelinux-openerp/openupgrade-server/AttributeErrorFix
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Approve
Review via email: mp+193141@code.launchpad.net

Description of the change

Addendum to [1] where some exceptions such as AttributeError' message may not be a string.

[1] https://code.launchpad.net/~savoirfairelinux-openerp/openupgrade-server/OperationalError/+merge/192740

To post a comment you must log in.
Revision history for this message
Sylvain LE GAL (GRAP) (sylvain-legal) wrote :

LGTM.

review: Approve
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openerp/openupgrade/openupgrade.py'
--- openerp/openupgrade/openupgrade.py 2013-10-21 14:28:15 +0000
+++ openerp/openupgrade/openupgrade.py 2013-10-29 21:23:04 +0000
@@ -461,7 +461,7 @@
461 except Exception, e:461 except Exception, e:
462 logger.error(462 logger.error(
463 "%s: error in migration script %s: %s" % 463 "%s: error in migration script %s: %s" %
464 (module, filename, e.message.decode('utf8')))464 (module, filename, str(e).decode('utf8')))
465 logger.exception(e)465 logger.exception(e)
466 raise466 raise
467 return wrapped_function467 return wrapped_function

Subscribers

People subscribed via source and target branches