Code review comment for lp:~savoirfairelinux-openerp/openerp-hr/7.0-experience

Revision history for this message
Daniel Reis (dreis-pt) wrote :

To fix: you're missing the i18n .pot file.

On the design choices: I certainly wouldn't mix Experience, Academic and Certifications.

Experience is mostly informative.
Academic can have reporting implications, so I might need to have Academic mandatory, but leave Experience optional.
This tips me that they should be two different fields on the employee form.

About Certification, they are more like Skills than Experience.
In fact, they are Certified Skills, and would be better off as an enhancement on the skills modules.

Another thing that makes me uneasy: this works only Employees, what about Applicants? (I know, it's not an easy question, but I suspect that here is a smart answer for it)

review: Needs Information

« Back to merge proposal