Code review comment for lp:~savoirfairelinux-openerp/openerp-fiscal-rules/7.0-fix-bug-1265067

Revision history for this message
Raphaƫl Valyi - http://www.akretion.com (rvalyi) wrote :

Hello Maxime,

are you sure?
I had the same bug as you reported but when I merged https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918-revert-hack/+merge/199144 it disappeared. Look how kwargs is defined in the MP, there is no way you'll have a uid key left.
As for web_context_tunnel, I was commenting only about how it's useful to inject extra args in the context, but in the right way (instead of just replacing the context as we were doing before), not sure you understand that, in any case what fixes the bug is this MP https://code.launchpad.net/~camptocamp/openerp-fiscal-rules/7.0-wrong-onchange-1255918-revert-hack/+merge/199144 not web_context_tunnel itself.

review: Needs Information

« Back to merge proposal