Code review comment for lp:~savoirfairelinux-openerp/banking-addons/loose-coupling

Revision history for this message
Ronald Portier (Therp) (rportier1962) wrote :

Just to say I support Virgil on #2, and sparse better then dense. In my experience this also makes not only for better reading and comprehension, but also for much easier debugging.

And I do not see the point of adding return True to functions where this does not have any meaning:
if a function contains (or detects) errors, it should throw an exception. No exception thrown means function did the work it was supposed to do.

« Back to merge proposal