Merge lp:~saviq/unity8/rating-non-interactive into lp:unity8

[Michał Sawicz]

Make rating stars in PreviewReviewDisplay.qml non-interactive.

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No.

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

 * Did you make sure that your branch does not contain spurious tags?
Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1010
http://jenkins.qa.ubuntu.com/job/unity8-ci/3319/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1553
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/323
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/413
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/413
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/413/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/413
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1832
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2540
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2540/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9276

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3319/rebuild

review: Approve (continuous-integration)

[Andrea Cimitan (cimi)]

inline

review: Needs Fixing

[lp:~saviq/unity8/rating-non-interactive]

1011. By Michał Sawicz on 2014-07-04

Just tap in 0,0.

[Andrea Cimitan (cimi)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
 * Did CI run pass? If not, please explain why.
Yes

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1011
http://jenkins.qa.ubuntu.com/job/unity8-ci/3323/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1565/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/327
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/417
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/417
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/417/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/417
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1844/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2560
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2560/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9297

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3323/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

Had to abort, job was stuck for a day...

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1011
http://jenkins.qa.ubuntu.com/job/unity8-ci/3337/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1595
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/341
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/431
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/431
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/431/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/431
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1870
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2596
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2596/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9332

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3337/rebuild

review: Approve (continuous-integration)

=== modified file 'qml/Dash/Previews/PreviewRatingDisplay.qml'
--- qml/Dash/Previews/PreviewRatingDisplay.qml	2014-04-08 17:09:35 +0000
+++ qml/Dash/Previews/PreviewRatingDisplay.qml	2014-07-04 07:42:13 +0000
@@ -61,6 +61,7 @@
                     size: 5
                     value: modelData["rating"] || -1
                     visible: value >= 0
+                    interactive: false
 
                     property var urlIconEmpty: widgetData["rating-icon-empty"]
                     property var urlIconFull: widgetData["rating-icon-full"]

=== modified file 'tests/qmltests/Dash/Previews/tst_PreviewRatingDisplay.qml'
--- tests/qmltests/Dash/Previews/tst_PreviewRatingDisplay.qml	2014-02-21 11:04:21 +0000
+++ tests/qmltests/Dash/Previews/tst_PreviewRatingDisplay.qml	2014-07-04 07:42:13 +0000
@@ -108,5 +108,18 @@
                 }
             }
         }
+
+        function test_non_interactive() {
+            previewRatingDisplay.widgetData = reviewsModel1;
+
+            var reviewItem = findChild(previewRatingDisplay, "reviewItem1");
+            var rating = findChild(reviewItem, "rating");
+
+            compare(rating.value, reviewsModel1["reviews"][1]["rating"]);
+
+            // Tap on first star
+            mouseClick(rating, 0, 0);
+            compare(rating.value, reviewsModel1["reviews"][1]["rating"]);
+        }
     }
 }