lp:~saviq/unity8/rating-non-interactive

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:unity8 at revision 1027

PS Jenkins bot (community): Approve (continuous-integration) on 2014-07-05

Andrea Cimitan (community): Approve on 2014-07-04

Diff: 34 lines (+14/-0)

2 files modified

qml/Dash/Previews/PreviewRatingDisplay.qml (+1/-0)
tests/qmltests/Dash/Previews/tst_PreviewRatingDisplay.qml (+13/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1337508: All review widgets are changable

Undecided

Fix Released

Link a bug report

Related blueprints

1011. By Michał Sawicz on 2014-07-04

Just tap in 0,0.

1010. By Michał Sawicz on 2014-07-03

Make rating in PreviewRatingDisplay.qml non-interactive.

1009. By PS Jenkins bot on 2014-07-03

Releasing 7.90+14.10.20140703.1-0ubuntu1

1008. By Renato Araujo Oliveira Filho on 2014-07-03

Create IndicatorsLight.qml component used to control indicator led.

A blue led will pulse if the message indicator is blue and screen is off.

1007. By Albert Astals Cid on 2014-07-03

Fix valgrind warning by not emitting reset on model destructor

That won't be supported until Qt 5.4

More info at https://bugreports.qt-project.org/browse/QTBUG-39780

Warning was

==16693== Invalid read of size 8
==16693== at 0x72B19A0: QQmlContext::isValid() const (qqmlcontext.cpp:231)
==16693== by 0x736C82B: QQmlDelegateModelPrivate::emitChanges() (qqmldelegatemodel.cpp:1412)
==16693== by 0x7372AE6: QQmlDelegateModel::_q_modelReset() (qqmldelegatemodel.cpp:1463)
==16693== by 0x7397224: QQmlDelegateModel::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (moc_qqmldelegatemodel_p.cpp:196)
==16693== by 0x739769E: QQmlDelegateModel::qt_metacall(QMetaObject::Call, int, void**) (moc_qqmldelegatemodel_p.cpp:292)
==16693== by 0x66379CC: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.3.0)
==16693== by 0x65AEEFD: QAbstractItemModel::endResetModel() (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.3.0)
==16693== by 0x23461EFD: FakeIndicatorsModel::unload() (fakeindicatorsmodel.cpp:53)
==16693== by 0x23461E13: FakeIndicatorsModel::~FakeIndicatorsModel() (fakeindicatorsmodel.cpp:34)
==16693== by 0x2345C073: QQmlPrivate::QQmlElement<FakeIndicatorsModel>::~QQmlElement() (in /home/tsdgeos_work/phablet/unity8/investigate_test_shell_crash/builddir/tests/mocks/Unity/Indicators/libIndicatorsFakeQml.so)
==16693== by 0x2345C0A3: QQmlPrivate::QQmlElement<FakeIndicatorsModel>::~QQmlElement() (qqmlprivate.h:106)
==16693== by 0x663636B: QObjectPrivate::deleteChildren() (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.3.0)
==16693== Address 0x1862d448 is 8 bytes inside a block of size 16 free'd
==16693== at 0x4C2C2BC: operator delete(void*) (vg_replace_malloc.c:503)
==16693== by 0x72B21B8: QQmlContextData::destroy() (qqmlcontext.cpp:647)
==16693== by 0x7293458: QQmlPrivate::qdeclarativeelement_destructor(QObject*) (qqmlengine.cpp:612)
==16693== by 0x6C0CADD: QQmlPrivate::QQmlElement<QQuickItem>::~QQmlElement() (qqmlprivate.h:105)
==16693== by 0x663636B: QObjectPrivate::deleteChildren() (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.3.0)
==16693== by 0x663F0EB: QObject::~QObject() (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.3.0)
==16693== by 0x6BF64B5: QQuickItem::~QQuickItem() (qquickitem.cpp:2064)
==16693== by 0x6C0CAE5: QQmlPrivate::QQmlElement<QQuickItem>::~QQmlElement() (qqmlprivate.h:106)
==16693== by 0x663636B: QObjectPrivate::deleteChildren() (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.3.0)
==16693== by 0x663F0EB: QObject::~QObject() (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.3.0)
==16693== by 0x6BF64B5: QQuickItem::~QQuickItem() (qquickitem.cpp:2064)
==16693== by 0x6C0CAE5: QQmlPrivate::QQmlElement<QQuickItem>::~QQmlElement() (qqmlprivate.h:106)
 Fixes: 1332598

1006. By Albert Astals Cid on 2014-07-03

EasingCurve: Initialize members

1005. By Michael Zanetti on 2014-07-03

change wording in launcher quicklist Fixes: 1332035

1004. By Michał Sawicz on 2014-07-03

Initial code for a payment button widget, to handle purchasing apps from the click scope.

1003. By Michael Zanetti on 2014-07-03

drop launcher item spacing Fixes: 1332022

1002. By Nick Dedekind on 2014-07-03

Moved [Message]MenuItemFacotory from Unity.Indicators plugin to qml folder.