Merge lp:~saviq/unity8/fix-generic-preview into lp:unity8

Proposed by Michał Sawicz
Status: Merged
Approved by: Michał Sawicz
Approved revision: 193
Merged at revision: 210
Proposed branch: lp:~saviq/unity8/fix-generic-preview
Merge into: lp:unity8
Diff against target: 39 lines (+10/-2)
1 file modified
Dash/Generic/GenericPreview.qml (+10/-2)
To merge this branch: bzr merge lp:~saviq/unity8/fix-generic-preview
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Albert Astals Cid (community) Approve
Review via email: mp+179932@code.launchpad.net

Commit message

Fix generic preview wrapping and force rich text parsing.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

As test, look for Elephant in the home scope and longpress in the one from the Info category

You'll see that without this, the text gets out of screen

Revision history for this message
Albert Astals Cid (aacid) wrote :

There's some small problems with wrapping sometimes, but it is a definite improvement over what we have, so i'm approving this and will log a bug about the wrapping since i don't see anything on our side that may be causing it (i.e. may very well be a Qt bug)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Much nicer

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Dash/Generic/GenericPreview.qml'
--- Dash/Generic/GenericPreview.qml 2013-08-09 10:06:19 +0000
+++ Dash/Generic/GenericPreview.qml 2013-08-16 09:08:14 +0000
@@ -74,25 +74,33 @@
74 spacing: units.gu(2)74 spacing: units.gu(2)
7575
76 Label {76 Label {
77 anchors { left: parent.left; right: parent.right }
77 visible: text != ""78 visible: text != ""
78 fontSize: "medium"79 fontSize: "medium"
79 opacity: 0.680 opacity: 0.6
80 color: "white"81 color: "white"
81 text: previewData.subtitle82 text: previewData.subtitle.replace(/[\r\n]+/g, "<br />")
82 style: Text.Raised83 style: Text.Raised
83 styleColor: "black"84 styleColor: "black"
84 wrapMode: Text.WordWrap85 wrapMode: Text.WordWrap
86 textFormat: Text.RichText
87 // FIXME: workaround for https://bugreports.qt-project.org/browse/QTBUG-33020
88 onWidthChanged: { wrapMode = Text.NoWrap; wrapMode = Text.WordWrap }
85 }89 }
8690
87 Label {91 Label {
92 anchors { left: parent.left; right: parent.right }
88 visible: text != ""93 visible: text != ""
89 fontSize: "small"94 fontSize: "small"
90 opacity: 0.695 opacity: 0.6
91 color: "white"96 color: "white"
92 text: previewData.description97 text: previewData.description.replace(/[\r\n]+/g, "<br />")
93 style: Text.Raised98 style: Text.Raised
94 styleColor: "black"99 styleColor: "black"
95 wrapMode: Text.WordWrap100 wrapMode: Text.WordWrap
101 textFormat: Text.RichText
102 // FIXME: workaround for https://bugreports.qt-project.org/browse/QTBUG-33020
103 onWidthChanged: { wrapMode = Text.NoWrap; wrapMode = Text.WordWrap }
96 }104 }
97 }105 }
98}106}

Subscribers

People subscribed via source and target branches