Code review comment for lp:~saviq/unity/phablet.flatten-qmltests

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> > add_custom_target(check make test CTEST_OUTPUT_ON_FAILURE=1)

> in our root level CMakeLists.txt, to support the Debian "check" target.
> We could indeed go with a dependency, but how do we pass the CTEST...
> there? Or is it actually needed?

I'd like to keep the CTEST_OUTPUT_ON_FAILURE, otherwise executing make check manually will be very cumbersome to debug when it fails.

I think you can set it via:

target_set_properties(check ENVIRONMENT CTEST_OUTPUT_ON_FAILURE=1)

(not sure on the syntax but you get the idea... export it to the environment)

« Back to merge proposal