Code review comment for lp:~saviq/unity/phablet.flatten-qmltests

W dniu 17.04.2013 00:09, Michi Henning pisze:
> if("${qmltest_NO_ADD_TEST}" STREQUAL FALSE AND NOT "${qmltest_DEFAULT_NO_ADD_TEST}" STREQUAL "TRUE")
> add_test(${qmltest_TARGET} make ${qmltest_TARGET})
>
> Calling make directly like this prevents building with other build tools, such as ninja. I think the correct way to do this is to a custom target with a DEPENDS. Jussi?

Hmm indeed, we should just as well put the same command in there.

We also have

> enable_testing()
> add_custom_target(check make test CTEST_OUTPUT_ON_FAILURE=1)

in our root level CMakeLists.txt, to support the Debian "check" target.
We could indeed go with a dependency, but how do we pass the CTEST...
there? Or is it actually needed?

--
Michał Sawicz <email address hidden>
Canonical Services Ltd.